fixing Firefox webdriver instantiation, closes #235 (#236)

* adding a failing mocked unit test * adding a fix
ElSnoMan · Mar 20, 2022 · c3660fb · c3660fb · nguyet0310 · Mar 23, 2022
1 parent 7ee9dc8
commit c3660fb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/pylenium/webdriver_factory.py b/pylenium/webdriver_factory.py
@@ -275,7 +275,7 @@ def build_firefox(
  return webdriver.Firefox(
  executable_path=local_path, options=options, capabilities=caps, **(webdriver_kwargs or {})
  )
- return webdriver.Firefox(GeckoDriverManager(version=version).install(), options=options, **(webdriver_kwargs or {}))
+ return webdriver.Firefox(executable_path=GeckoDriverManager(version=version).install(), options=options, **(webdriver_kwargs or {}))
 
 
 def build_ie(

diff --git a/tests/unit/test_bugfixes.py b/tests/unit/test_bugfixes.py
@@ -0,0 +1,14 @@
+from unittest.mock import patch, MagicMock
+from pylenium import webdriver_factory
+
+
+def test_235_webdriver_factory(tmpdir):
+ file_to_use = tmpdir / "file"
+ file_to_use.write("test")
+ gecko_mock = MagicMock()
+ gecko_mock.install.return_value = file_to_use
+ with patch("pylenium.webdriver_factory.GeckoDriverManager", return_value=gecko_mock):
+ with patch("pylenium.webdriver_factory.webdriver.firefox.webdriver.Service"):
+ with patch("pylenium.webdriver_factory.webdriver.firefox.webdriver.RemoteWebDriver"):
+ webdriver_factory.build_firefox("latest", ["headless"], {}, [], [], "", {})
+ gecko_mock.install.assert_called_once()