Feature branch for 0.7.0 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
ffi-0.7.0
branch
2 times, most recently
from
d5d609c to
7860e5e
Compare
nuttycom
approved these changes
Mar 14, 2024
Includes changes to how accounts are stored and referenced. We now need to remember and provide the seed fingerprint; for now, given that we know we only create derived accounts from a single seed, we search for an account with a matching ZIP 32 account index.
nuttycom
approved these changes
Mar 15, 2024
daira
reviewed
Mar 15, 2024
| /// Returns: | ||
| /// - `1` for `Ok(true)`. | ||
| /// - `0` for `Ok(false)`. | ||
| /// - `-1` for `Err(_)`. |
There was a problem hiding this comment.
Add safety documentation of arguments.
daira
reviewed
Mar 15, 2024
This fixes a bug in the `v_transactions` view related to changes in how primary key columns are named in the database.
Includes some renames, and a built-in seed relevancy API that we now use.
Merged
14 tasks
This enables generation of Orchard receivers for unified addresses by default.
Updates to: - zcash_primitives 0.15.0 - zcash_proofs 0.15.0 - zcash_client_backend 0.12.0 - zcash_client_sqlite 0.10.0
str4d
commented
Mar 25, 2024
daira
reviewed
Mar 25, 2024
| * | ||
| * Returns: | ||
| * - `1` for `Ok(true)`. | ||
| * - `0` for `Ok(false)`. |
There was a problem hiding this comment.
Non-blocking: Ideally, documentation at this level would not depend on knowing the semantics of the corresponding Rust function (which isn't linked here).
daira
reviewed
Mar 25, 2024
| @@ -1013,6 +1093,8 @@ struct FfiScanSummary *zcashlc_scan_blocks(const uint8_t *fs_block_cache_root, | |||
| const uint8_t *db_data, | |||
| uintptr_t db_data_len, | |||
| int32_t from_height, | |||
| const uint8_t *from_state, | |||
| uintptr_t from_state_len, | |||
There was a problem hiding this comment.
These new parameters have not been documented in the safety section. Non-blocking but please file an issue if it isn't fixed now.
daira
reviewed
Mar 25, 2024
daira
reviewed
Mar 25, 2024
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payments to TEX addresses supported.