Release 0.12.0 #180
Merged
Release 0.12.0 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the use of imported UFVKs.
…tadata accessor. Also, do not attempt to create key source data from the null pointer.
Use UUIDs instead of 32-bit indexes for account identifiers.
…derivation` module.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Add methods for deriving addresses from UFVK and UIVK values to the `derivation` module.
…cos-13.3 Move off of the deprecated macos-12 builder.
…tion_fix Fix incorrect Orchard key derivation paths.
…chard_proofs Update to `orchard` version `5b6cc68b746c4dab37e43d09314da98d5ee99c21`
Remove `zcashlc_get_memo_as_utf8`
…ustzcash` crates.
…ress Update to released versions of `orchard`, `sapling-crypto` and the `librustzcash` crates.
14 tasks
str4d
commented
Jan 9, 2025
| network_id: u32, | ||
| ) -> *mut FFIBinaryKey { | ||
| ) -> *mut FfiBoxedSlice { |
There was a problem hiding this comment.
Should have been documented as a change in the changelog.
| /// A struct that contains a Zcash unified address, along with the diversifier index used to | ||
| /// generate that address. | ||
| #[repr(C)] | ||
| pub struct FfiAddress { |
There was a problem hiding this comment.
Should have been documented as an addition in the changelog.
| /// | ||
| /// - `ptr` must be non-null and must point to a struct having the layout of [`FfiAddress`]. | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn zcashlc_free_ffi_address(ptr: *mut FfiAddress) { |
There was a problem hiding this comment.
Should have been documented as an addition in the changelog.
|
|
||
| UnifiedSpendingKey::from_seed(&network, seed, account) | ||
| .map_err(|e| anyhow!("error generating unified spending key from seed: {:?}", e)) | ||
| .map(move |usk| { | ||
| let encoded = usk.to_bytes(Era::Orchard); | ||
| Box::into_raw(Box::new(FFIBinaryKey::new(account, encoded))) | ||
| FfiBoxedSlice::some(encoded) |
There was a problem hiding this comment.
Need to document that this method does not use the FfiBoxedSlice::none variant.
| seed_fingerprint: [u8; 32], | ||
| account_index: u32, | ||
| hd_account_index: u32, |
There was a problem hiding this comment.
Changes should have been documented in the changelog.
| #[no_mangle] | ||
| pub unsafe extern "C" fn zcashlc_get_total_transparent_balance_for_account( | ||
| db_data: *const u8, | ||
| db_data_len: usize, | ||
| network_id: u32, | ||
| account: i32, | ||
| account_uuid_bytes: *const u8, |
There was a problem hiding this comment.
Change should have been documented in the changelog.
| @@ -1626,7 +1698,7 @@ impl FfiBalance { | |||
| /// The sum of this struct's fields is the total balance of the account. | |||
| #[repr(C)] | |||
| pub struct FfiAccountBalance { | |||
| account_id: u32, | |||
| account_uuid: [u8; 16], | |||
There was a problem hiding this comment.
Change should have been documented in the changelog.
| @@ -2433,7 +2495,7 @@ pub unsafe extern "C" fn zcashlc_free_boxed_slice(ptr: *mut FfiBoxedSlice) { | |||
| pub unsafe extern "C" fn zcashlc_propose_transfer( | |||
| db_data: *const u8, | |||
| db_data_len: usize, | |||
| account: i32, | |||
| account_uuid_bytes: *const u8, | |||
There was a problem hiding this comment.
Change should have been documented in the changelog.
| @@ -2511,7 +2577,7 @@ pub unsafe extern "C" fn zcashlc_propose_transfer( | |||
| pub unsafe extern "C" fn zcashlc_propose_transfer_from_uri( | |||
| db_data: *const u8, | |||
| db_data_len: usize, | |||
| account: i32, | |||
| account_uuid_bytes: *const u8, | |||
There was a problem hiding this comment.
Change should have been documented in the changelog.
| /// - `shielding_threshold` a non-negative shielding threshold amount in zatoshi | ||
| /// - Call [`zcashlc_free_boxed_slice`] to free the memory associated with the returned | ||
| /// pointer when done using it. | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn zcashlc_propose_shielding( | ||
| db_data: *const u8, | ||
| db_data_len: usize, | ||
| account: i32, | ||
| account_uuid_bytes: *const u8, |
There was a problem hiding this comment.
Change should have been documented in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking PR for the changes being accumulated for the 0.12.0 release.
This PR's branch MUST NOT be rebased, and MUST NOT be squash-merged.
Closes #168.