Create node.js.yml #18
Conversation
…obility/elmo-discord-bot into Jerry-github-actions
…obility/elmo-discord-bot into Jerry-github-actions
|
Please review my PR! |
| @@ -2,11 +2,14 @@ const { SlashCommandBuilder, PermissionFlagsBits } = require('discord.js'); | |||
| /* ---------------------- | |||
| Google Sheets Setup | |||
| -------------------------- */ | |||
| const { spreadsheetId } = require('../../config.json'); | |||
| //const { spreadsheetId } = require('../../config.json'); | |||
There was a problem hiding this comment.
is there a reason we're getting rid of the config.json?
There was a problem hiding this comment.
Github action are unable to read files being gitignored. We passed github secrets as environment variables instead
| @@ -1,5 +1,8 @@ | |||
| const { REST, Routes } = require('discord.js'); | |||
| const { clientId, guildId, token } = require('./config.json'); | |||
| //const { clientId, guildId, token } = require('./config.json'); | |||
There was a problem hiding this comment.
will have to change a lot of stuff if we go from config.json -> .env, especially how we build. pros /cons of this?
There was a problem hiding this comment.
Pros: github action automate this process once we have CI configured. Cons: have to change github secrets if we change anything in config.json
|
i feel like this will break everyones code LOL |
Yea, I agree. We should only use this if we have finished building every functionality and are ready to deploy to VM. |
No description provided.