Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ESLinter #38

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

carlxw
Copy link
Contributor

@carlxw carlxw commented Mar 14, 2024

Hi everyone, prior to merging, please check if these rules are what we want to be enforced. Everybody does have different coding practices, so please take the time to review what we should add/remove before merging this into main.

Here's some good references:

@sherwinchiu
Copy link
Contributor

@sherwinchiu
Copy link
Contributor

can we just do the default for ESLinter? i think that should be good enough, and then we can go from there

@carlxw
Copy link
Contributor Author

carlxw commented Apr 2, 2024

@sherwinchiu What exactly do you mean by "default"?

@carlxw
Copy link
Contributor Author

carlxw commented May 2, 2024

TLDR

  • Added ESLinter with JS Code Standard with a few other rules
  • Added Husky to lint pre-commit
    • This feature is currently disabled because ALL files are going to need lots of work before re-enabling this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants