Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLN service startup failure by trimming trailing spaces in config parameters #7251

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix CLN service startup failure by trimming trailing spaces in config parameters #7251

merged 2 commits into from
Aug 10, 2024

Commits on Aug 9, 2024

  1. lightningd: trim whitespaces from end of config parameters 

    Signed-off-by: Max Rantil <rantil@pm.me>
    @maxrantil
    maxrantil committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    189cc97 View commit details
    Browse the repository at this point in the history

  2. lightningd: configvar style fixes 

    1) We can't simply cast away const to manipulate a string, the compiler can assume
   we don't.  The type must be made non-const.
2) cisspace() is nicer to use than isspace() (no cast required!)
3) Simply place a NUL terminator instead of using memmove to set it.
4) Use cast_const to add const to char **, where necessary.
5) Add Changelog line, for CHANGELOG.md

Changelog-Fixed: Config: whitespace at the end of (most) options is now ignored, not complained about.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @maxrantil
    rustyrussell authored and maxrantil committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2a234b2 View commit details
    Browse the repository at this point in the history