bookkeeper testing for splice-in + splice-out #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/bkpr_splice_two
branch
2 times, most recently
from
efd2ea1
to
97b134c
Compare
niftynei
force-pushed
the
nifty/bkpr_splice_two
branch
from
97b134c
to
aa83153
Compare
|
LGTM! Excited for all this bookeeper checking! The A rebase will be needed once that PR passes CI |
niftynei
force-pushed
the
nifty/bkpr_splice_two
branch
2 times, most recently
from
9ff59df
to
c4f90c7
Compare
rustyrussell
force-pushed
the
nifty/bkpr_splice_two
branch
from
c4f90c7
to
7003306
Compare
Make sure that the fees and channel balances for splice ins and outs work as expected. Note this is for a single-sided splice. Changelog-None: Tests!
rustyrussell
force-pushed
the
nifty/bkpr_splice_two
branch
from
7003306
to
8ebe08a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for bookkeeping for splicing. Test that funds are allocated and accounted for appropriately, along with on-chain fees, for both splice-in and splice-out.
Note that fees for splices are attributed to the channels that the funds are spliced into/out of.
Built on #7533 and #6980. Start at commit 01da483.
[Those are merged! Rebased on master --RR]
Changelog-None: just tests...