Rebase of PR #7556 #7803
Merged
Rebase of PR #7556 #7803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
approved these changes
Nov 12, 2024
|
This might require an update mocks call, the flake build is failing in run route overlong not having the mocks for tracing related functions. |
JssDWt
reviewed
Nov 12, 2024
plugins/libplugin.c
Outdated
|
|
||
| /* Annotate the JSON-RPC span whether it succeeded or failed, | ||
| * and then emit it. */ | ||
| trace_span_tag(out, "error", contenttok == NULL ? "true" : "false"); |
There was a problem hiding this comment.
This needs to be the other way around
Suggested change
| trace_span_tag(out, "error", contenttok == NULL ? "true" : "false"); | |
| trace_span_tag(out, "error", contenttok == NULL ? "false" : "true"); |
There was a problem hiding this comment.
That's two negatives. I will change it to contenttok ? "true" : "false"
The `send_outreq` function is a good place to suspend and resume traces, since these are usually the places where we hand off control back to the `io_loop`. This assumes that we do not continue doing heavy liftin after we have queued an `outreq` call, but that is most likely the case anyway. This frees us from having to track suspensions whenever we call the RPC from a plugin.
rustyrussell
force-pushed
the
guilt/pr-7556
branch
from
73e83c6
to
e8914b3
Compare
Changelog-Added: Plugins: `pay` now has tracing support for various payment steps.
rustyrussell
force-pushed
the
guilt/pr-7556
branch
from
e8914b3
to
b65fcbe
Compare
JssDWt
approved these changes
Nov 13, 2024
|
Unrelated faulure inside the CI merging this, and opening an issue for the CI faulure |
vincenzopalazzo
merged commit 087a29b
into
ElementsProject:master
30 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this:
Closes: #7575
Closes: #7556 ?