More flake fixes. #7866
Merged
More flake fixes. #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/fix-flakes10
branch
from
1bd700b
to
c3317bd
Compare
They're not always 34 (aka '"'). This is a side-effect of ids changing from u64 to strings quite a while ago. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Create lower-level versions of routines to create biases, layers, constraints, etc and only save the ones called from the public APIs. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-None: persistent layers were only added in this release
No code changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…loading. Using jsonrpc_request_sync, layers are loaded before we finish init, so we never can be asked to create a layer before we've loaded it (xpay creates a layer immediately on startup). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-None: persistent layers new this release.
rustyrussell
force-pushed
the
guilt/fix-flakes10
branch
from
c3317bd
to
bf052db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, so far one xpay - askrene layer fix, and one "mfc thinks every multifundchannel has id 34" fix.
Changelog-None