Address err refactor #210
Merged
Address err refactor #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is propedeutic to upgrading to bitcoin 0.32 where this address-related variants are removed from base58::Error
RCasatta
force-pushed
the
address_err_refactor
branch
from
f393297 to
084f7d4
Compare
RCasatta
force-pushed
the
address_err_refactor
branch
3 times, most recently
from
c253869 to
448b3bb
Compare
RCasatta
force-pushed
the
address_err_refactor
branch
from
448b3bb to
4269728
Compare
Merged
|
CI failures are on master, and appear to require we add some more pins (or fixed lockfiles) to CI. I'm fine to ignore it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is propedeutic to upgrade to bitcoin 0.32 #209
where the base58 error variant specific to address are removed
Also it applies formatting around on which I think we agreed upon, but also on the toml file which I had doubt, let me know if I have to remove it