ply Writer rewrite WIP

EliCDavis · Dec 21, 2024 · 5cc9753 · 5cc9753
1 parent 3b39e14
commit 5cc9753
Show file tree

Hide file tree

Showing 19 changed files with 1,114 additions and 42 deletions.
diff --git a/README.md b/README.md
@@ -344,6 +344,9 @@ Resources either directly contributing to the code, or are just interesting find
   - [https://github.com/shg8/VulkanSplatting](https://github.com/shg8/VulkanSplatting)
   - [Making Gaussian Splats Smaller](https://aras-p.info/blog/2023/09/13/Making-Gaussian-Splats-smaller/) by [Aras Pranckevičius](https://aras-p.info/)
   - [Gaussian Explosion](https://aras-p.info/blog/2023/12/08/Gaussian-explosion/) by [Aras Pranckevičius](https://aras-p.info/)
+  - Rotating
+    - [Thread on Rotating](https://github.com/graphdeco-inria/gaussian-splatting/issues/176)
+    - [Winger D Matrix Wikipedia Article](https://en.wikipedia.org/wiki/Wigner_D-matrix) (required for rotating spherical harmonics)
 - Coloring Stuff
   - Color Grading LUT
     - [_3D Game Shaders For Beginners - Lookup Table (LUT)_ by David Lettier](https://lettier.github.io/3d-game-shaders-for-beginners/lookup-table.html)

diff --git a/examples/edit-gaussian-splats/main.go b/examples/edit-gaussian-splats/main.go
@@ -35,17 +35,17 @@ func main() {
 		},
 	}
 
-	filteredCloud := &gausops.FilterNode{
-		Data: gausops.FilterNodeData{
-			Splat:      pointcloud.Out(),
-			MinOpacity: &parameter.Float64{Name: "Minimum Opacity"},
-			MinVolume:  &parameter.Float64{Name: "Minimum Scale"},
-			MaxVolume: &parameter.Float64{
-				Name:         "Maximum Scale",
-				DefaultValue: 1000.,
-			},
-		},
-	}
+	// filteredCloud := &gausops.FilterNode{
+	// 	Data: gausops.FilterNodeData{
+	// 		Splat:      pointcloud.Out(),
+	// 		MinOpacity: &parameter.Float64{Name: "Minimum Opacity"},
+	// 		MinVolume:  &parameter.Float64{Name: "Minimum Scale"},
+	// 		MaxVolume: &parameter.Float64{
+	// 			Name:         "Maximum Scale",
+	// 			DefaultValue: 1000.,
+	// 		},
+	// 	},
+	// }
 
 	rotateAmount := &quatn.FromTheta{
 		Data: quatn.FromThetaData{
@@ -75,7 +75,7 @@ func main() {
 		Data: gausops.RotateAttributeNodeData{
 			Mesh: &meshops.RotateAttribute3DNode{
 				Data: meshops.RotateAttribute3DNodeData{
-					Mesh:   filteredCloud.Out(),
+					Mesh:   pointcloud.Out(),
 					Amount: rotateAmount,
 				},
 			},
@@ -159,7 +159,7 @@ func main() {
 			XrEnabled: true,
 		},
 		Producers: map[string]nodes.NodeOutput[generator.Artifact]{
-			"mesh.ply": artifact.NewSplatPlyNode(colorGraded.Out()),
+			"mesh.ply": artifact.NewSplatPlyNode(pointcloud.Out()),
 			"info.txt": artifact.NewTextNode(&InfoNode{
 				Data: InfoNodeData{
 					Original: pointcloud.Out(),

diff --git a/formats/ply/ply_test.go b/formats/ply/ply_test.go
@@ -151,7 +151,7 @@ func TestToMeshLittleEndian(t *testing.T) {
 		return
 	}
 
-	bunny, err := ply.ReadMesh(bytes.NewBuffer(data))
+	bunny, err := ply.ReadMesh2(bytes.NewBuffer(data))
 
 	assert.NoError(t, err)
 	assert.NotNil(t, bunny)
@@ -165,7 +165,7 @@ func TestToMeshLittleEndianTextured(t *testing.T) {
 		return
 	}
 
-	covid, err := ply.ReadMesh(bytes.NewBuffer(data))
+	covid, err := ply.ReadMesh2(bytes.NewBuffer(data))
 
 	assert.NoError(t, err)
 	assert.NotNil(t, covid)