Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

v3.0.4

Compare
Choose a tag to compare
@edwinljacobs edwinljacobs released this 11 Nov 11:53
· 232 commits to master since this release
08aba54

Fixed issue EmicoEcommerce/Magento2Tweakwise#129 Thanks to ArjenMiedema for pointing this out and providing a possible solution.

When url path strategy is enabled the url matching is more strict. The case is as follows: With path strategy enabled filter urls are constructed as
https://site.com/category/filterName/filterValue, this will render the category with filter "filterName" selected at the correct value. The url matching is done by looking at the current request path and checking if there is any part of the request path that corresponds to a category url (or landingpage if that module is enabled), if so we render the longest category match and treat the remaining part of the request path as filters. The resulting behaviour is that https://site.com/category/any-nonsense yields a 200 O.K because the path strategy matches this url. This is because we cannot know in advance what the valid filters are (this is in part due to derived filters). This release features a partial fix to this issue, since each filter consists of a filterName and a filterValue there should at least be an even number of path segments in the remaining request path. If this is not the case we dont match the url anymore.