This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running an agent in a macho binary, we have an issue where any modules that make use of
sys.argv
(directly or indirectly through dependencies) fail becausesys.argv
hasn't been set. We get the following error:If this same module is run from a python one-liner the error doesn't appear.
This PR attempts to fix this problem by changing the template so that
argc
andargv
are passed to Python before the agent is run. From here, any references tosys.argv
should not result in failure.Note: I have not compiled this code (no current access to OSX), but I think it should just work out of the box.