a new approach

Emurgo · Jun 23, 2024 · c4feef9 · c4feef9
1 parent 9883d0b
commit c4feef9
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 35 deletions.
diff --git a/.github/workflows/e2e-test-build.yml b/.github/workflows/e2e-test-build.yml
@@ -0,0 +1,43 @@
+name: E2E Test Build
+
+on:
+  workflow_dispatch:
+  pull_request:
+    types: [opened, ready_for_review]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  Build-Extension:
+    if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check') || contains(github.event.review.body, '/ext-general') || contains(github.event.review.body, '/ext-failing'))
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Read .nvmrc
+        id: nvm
+        run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
+
+      - name: Setup node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "${{ steps.nvm.outputs.NVMRC }}"
+
+      - name: npm install
+        run: |
+          . install-all.sh
+
+      - name: Build the test mainnet version
+        working-directory: ./packages/yoroi-extension
+        run: npm run test:build:mainnet
+
+      - name: Archive built app
+        uses: actions/upload-artifact@v4
+        with:
+          name: builtApp
+          path: |
+            ./packages/yoroi-extension/Yoroi-test.crx
+            ./packages/yoroi-extension/Yoroi.xpi
+          retention-days: 1
+          overwrite: true
diff --git a/.github/workflows/e2e-tests-ext.yml b/.github/workflows/e2e-tests-ext.yml
@@ -6,46 +6,15 @@ on:
     types: [opened, ready_for_review]
   pull_request_review:
     types: [submitted]
+  workflow_run:
+    workflows: [E2E Test Build]
+    types:
+      - completed
 
 jobs:
-  Build-Extension:
-    if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check') || contains(github.event.review.body, '/ext-general') || contains(github.event.review.body, '/ext-failing'))
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Read .nvmrc
-        id: nvm
-        run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
-
-      - name: Setup node
-        uses: actions/setup-node@v4
-        with:
-          node-version: "${{ steps.nvm.outputs.NVMRC }}"
-
-      - name: npm install
-        run: |
-          . install-all.sh
-
-      - name: Build the test mainnet version
-        working-directory: ./packages/yoroi-extension
-        run: npm run test:build:mainnet
-
-      - name: Archive built app
-        uses: actions/upload-artifact@v4
-        with:
-          name: builtApp
-          path: |
-            ./packages/yoroi-extension/Yoroi-test.crx
-            ./packages/yoroi-extension/Yoroi.xpi
-          retention-days: 1
-          overwrite: true
-
   Ext-General:
     if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check') || contains(github.event.review.body, '/ext-general'))
     runs-on: macos-latest
-    needs: Build-Extension
     strategy:
       matrix:
         browser: ["chrome"]