Connector: disconnects #1994
Merged
Connector: disconnects #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port disconnects cause the disconnect event to be dispatched to the dApp. Removing a site from the whitelist disconnects the associated port, if it exists (e.g. actively connected). Ports are now only initiated upon a request for read access to avoid creating many ports for non-dApp websites.
| @@ -139,6 +114,8 @@ class ErgoAPI { | |||
|
|
|||
| const ergo = Object.freeze(new ErgoAPI()); | |||
| ` | |||
| const API_INTERNAL_ERROR = -2; | |||
There was a problem hiding this comment.
Three things:
- Maybe these error codes should be documented somewhere?
- Maybe these should should be in an enum instead of two separate variables
- Why does it start at -2 instead of -1? Is -1 used for something else? Maybe document this
There was a problem hiding this comment.
ergoplatform/eips#23 they're documented here in the EIP-0012 spec. They do start at -1, but we just don't reject things for InvalidRequest: -1 in the connector since input data verification happens elsewhere.
SebastienGllmt
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port disconnects cause the disconnect event to be dispatched to the
dApp.
Removing a site from the whitelist disconnects the associated port, if
it exists (e.g. actively connected).
Ports are now only initiated upon a request for read access to avoid
creating many ports for non-dApp websites.