initial zoom integration #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SourceLevel has finished reviewing this Pull Request and has found:
But beware that this branch is 319 commits behind the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small change, we shall see if the zoom needs to be augmented for tilt enabled systems. Basic idea is FE already grabs zoom from the SV urls (if that's how they are being added) and can easily send it along as an assetAttribute. assetAttributes get picked up by the director api and converted to elements in the activity_config. All we are doing now is taking them (if they exist) instead of using the maths involving FOV.