-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More FlightEndpoint attributes #2
More FlightEndpoint attributes #2
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
61fe0b5
to
7cad472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments and I'm not a cython expert but it looks good to me 👍
|
||
|
||
cdef extern from "<chrono>" namespace "std::chrono": | ||
cdef cppclass duration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why the template parameter isn't needed here, but I guess it's inferred from the constructor parameter type and/or count return type?
3d69078
to
2c8bfa3
Compare
2c8bfa3
to
cf01691
Compare
7cad472
to
11b5b3c
Compare
Thanks for the code review, raised upstream: apache#43537. |
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?