Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More FlightEndpoint attributes #2

Closed

Conversation

EnricoMi
Copy link
Owner

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@EnricoMi EnricoMi changed the base branch from main to more-flightinfo-attributes July 24, 2024 19:34
@EnricoMi EnricoMi force-pushed the more-flightendpoint-attributes branch 3 times, most recently from 61fe0b5 to 7cad472 Compare July 25, 2024 18:27
Copy link

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments and I'm not a cython expert but it looks good to me 👍

python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved
python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved


cdef extern from "<chrono>" namespace "std::chrono":
cdef cppclass duration:
Copy link

@adamreeve adamreeve Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why the template parameter isn't needed here, but I guess it's inferred from the constructor parameter type and/or count return type?

@EnricoMi EnricoMi force-pushed the more-flightendpoint-attributes branch from 7cad472 to 11b5b3c Compare July 26, 2024 08:11
@EnricoMi
Copy link
Owner Author

EnricoMi commented Aug 2, 2024

Thanks for the code review, raised upstream: apache#43537.

@EnricoMi EnricoMi closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants