please pass

Enterprise-CMCS · Jan 22, 2024 · 3504b4c · 3504b4c
1 parent d7711dc
commit 3504b4c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/services/app-api/src/handlers/third_party_API_authorizer.ts b/services/app-api/src/handlers/third_party_API_authorizer.ts
@@ -9,7 +9,7 @@ import { newJWTLib } from '../jwt'
 // Hard coding this for now, next job is to run this config to this app.
 const jwtLib = newJWTLib({
     issuer: 'fakeIssuer',
-    signingKey: 'notrandom',
+    signingKey: Buffer.from('123af', 'hex'),
     expirationDurationS: 90 * 24 * 60 * 60, // 90 days
 })
 

diff --git a/services/app-api/src/jwt/jwt.test.ts b/services/app-api/src/jwt/jwt.test.ts
@@ -4,7 +4,7 @@ describe('jwtLib', () => {
     it('works symmetricly', () => {
         const jwt = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo', //pragma: allowlist secret
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 
@@ -27,13 +27,13 @@ describe('jwtLib', () => {
     it('errors with wrong issuer', () => {
         const jwtWriter = newJWTLib({
             issuer: 'wrong',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 
         const jwtReader = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 
@@ -49,13 +49,13 @@ describe('jwtLib', () => {
     it('errors with bad expiration', () => {
         const jwtWriter = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 0,
         })
 
         const jwtReader = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 
@@ -77,7 +77,7 @@ describe('jwtLib', () => {
 
         const jwtReader = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 
@@ -93,7 +93,7 @@ describe('jwtLib', () => {
     it('errors with bogus JWT', () => {
         const jwtReader = newJWTLib({
             issuer: 'mctest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 

diff --git a/services/app-api/src/resolvers/APIKey/createAPIKey.test.ts b/services/app-api/src/resolvers/APIKey/createAPIKey.test.ts
@@ -7,7 +7,7 @@ describe('createAPIKey', () => {
     it('creates a new API key', async () => {
         const jwt = newJWTLib({
             issuer: 'mctestiss',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 

diff --git a/services/app-api/src/testHelpers/gqlHelpers.ts b/services/app-api/src/testHelpers/gqlHelpers.ts
@@ -91,7 +91,7 @@ const constructTestPostgresServer = async (opts?: {
         opts?.jwt ||
         newJWTLib({
             issuer: 'mcreviewtest',
-            signingKey: 'foo',
+            signingKey: Buffer.from('123af', 'hex'),
             expirationDurationS: 1000,
         })
 

diff --git a/services/infra-api/serverless.yml b/services/infra-api/serverless.yml
@@ -230,6 +230,7 @@ resources:
         Name: 'api_jwt_secret_${sls:stage}'
         Description: 'Dynamically generated secret for JWT signing/validation'
         GenerateSecretString:
+          SecretStringTemplate: '{}'
           GenerateStringKey: jwtsigningkey
           PasswordLength: 128
           ExcludePunctuation: true