Skip to content

Commit

Permalink
Bump actions download and upload artifact from 3 to 4 (#2132)
Browse files Browse the repository at this point in the history
* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* try sha

* Change branch.

* Change duplicate artifact name.

* Change duplicate artifact name.

* Change duplicate artifact name.

* Clean up

* Some more Artifact name changes.

* Artifact name change again

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mojo Talantikite <mojo.talantikite@gmail.com>
  • Loading branch information
3 people authored Dec 20, 2023
1 parent 5c86975 commit 5598774
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 28 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/deploy-app-to-env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,18 @@ jobs:
run: npx lerna run generate

- name: upload app web gen directory
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: app-web-gen
name: app-web-gen deploy
path: ./services/app-web/src/gen

- name: upload cypress gen directory
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: cypress-gen
name: cypress-gen deploy
path: ./services/cypress/gen

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: lambda-layers-prisma-client-migration
path: ./services/app-api/lambda-layers-prisma-client-migration
Expand All @@ -104,7 +104,7 @@ jobs:
tar -C ./services/app-api/lambda-layers-prisma-client-migration -xf ./services/app-api/lambda-layers-prisma-client-migration/nodejs.tar.gz
rm -rf ./services/app-api/lambda-layers-prisma-client-migration/nodejs.tar.gz
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: lambda-layers-prisma-client-engine
path: ./services/app-api/lambda-layers-prisma-client-engine
Expand Down
34 changes: 17 additions & 17 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,19 @@ jobs:
run: yarn test:once --coverage

- name: upload app web gen directory
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: app-web-gen
path: ./services/app-web/src/gen

- name: upload cypress gen directory
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: cypress-gen
path: ./services/cypress/gen

- name: upload unit test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: unit-test-coverage
path: ./services/app-web/coverage/coverage-final.json
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
yarn test:once --coverage
- name: upload api test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: api-test-coverage
path: ./services/app-api/coverage/coverage-final.json
Expand Down Expand Up @@ -239,12 +239,12 @@ jobs:
working-directory: services/app-api
run: ./scripts/prepare-prisma-layer.sh

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: lambda-layers-prisma-client-migration
path: ./services/app-api/lambda-layers-prisma-client-migration

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: lambda-layers-prisma-client-engine
path: ./services/app-api/lambda-layers-prisma-client-engine
Expand Down Expand Up @@ -278,7 +278,7 @@ jobs:
needs.api-unit-tests.result == 'success' &&
needs.build-prisma-client-lambda-layer.result == 'success' &&
needs.begin-deployment.result == 'success'
uses: Enterprise-CMCS/managed-care-review/.github/workflows/deploy-app-to-env.yml@main
uses: Enterprise-CMCS/managed-care-review/.github/workflows/deploy-app-to-env.yml@Bump-actions-download-and-upload-artifact-from-3-to-4
with:
environment: dev
stage_name: ${{ needs.begin-deployment.outputs.stage-name }}
Expand Down Expand Up @@ -458,12 +458,12 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: app-web-gen
path: ./services/app-web/src/gen

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cypress-gen
path: ./services/cypress/gen
Expand Down Expand Up @@ -508,26 +508,26 @@ jobs:
CYPRESS_VIDEOS_FOLDER: services/cypress/videos

- name: Upload cypress screenshots
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && steps.cypress.outcome == 'failure'
with:
name: cypress-screenshots
name: cypress-screenshots-${{ matrix.containers}}
path: services/cypress/screenshots

- name: Upload cypress video
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always() && steps.cypress.outcome != 'skipped'
with:
name: cypress-videos
name: cypress-videos-${{ matrix.containers}}
path: services/cypress/videos
- name: upload partial cypress coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: partial-cypress-coverage-${{ matrix.containers}}
path: ./coverage-cypress/lcov.info

- name: upload partial cypress coverage json
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: cypress-json-coverage-${{ matrix.containers}}
path: ./coverage-cypress/coverage-final.json
Expand Down Expand Up @@ -560,7 +560,7 @@ jobs:
echo $(pwd)
ls
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4

- name: Create combined test coverage report
run: |
Expand Down Expand Up @@ -597,7 +597,7 @@ jobs:
cd coverage-all
echo "Coverage reports merged"
- name: Upload combined test coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: combined-test-coverage
path: ./coverage-all/
10 changes: 5 additions & 5 deletions .github/workflows/promote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ jobs:
working-directory: services/app-api
run: ./scripts/prepare-prisma-layer.sh

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: lambda-layers-prisma-client-migration
path: ./services/app-api/lambda-layers-prisma-client-migration

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: lambda-layers-prisma-client-engine
path: ./services/app-api/lambda-layers-prisma-client-engine
Expand Down Expand Up @@ -223,12 +223,12 @@ jobs:
- name: Setup env
uses: ./.github/actions/setup_env

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: app-web-gen
path: ./services/app-web/src/gen

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: cypress-gen
path: ./services/cypress/gen
Expand Down Expand Up @@ -264,7 +264,7 @@ jobs:
CYPRESS_VIDEOS_FOLDER: services/cypress/videos

- name: Upload cypress video
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure() && steps.cypress.outcome == 'failure'
with:
name: cypress-videos
Expand Down

0 comments on commit 5598774

Please sign in to comment.