Fixed schema and add new tests.

Enterprise-CMCS · Jul 13, 2023 · 6ad0f18 · 6ad0f18
1 parent 2c806ad
commit 6ad0f18
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/services/app-api/src/domain-models/contractAndRates/contractAndRatesZodSchema.ts b/services/app-api/src/domain-models/contractAndRates/contractAndRatesZodSchema.ts
@@ -22,7 +22,7 @@ const contractFormDataSchema = z.object({
     addtlActuaryCommunicationPreference:
         actuaryCommunicationTypeSchema.optional(),
     supportingDocuments: z.array(submissionDocumentSchema),
-    contractType: contractTypeSchema.optional(),
+    contractType: contractTypeSchema,
     contractExecutionStatus: contractExecutionStatusSchema.optional(),
     contractDocuments: z.array(submissionDocumentSchema),
     contractDateStart: z.date().optional(),

diff --git a/services/app-api/src/domain-models/contractAndRates/parseDomainData.test.ts b/services/app-api/src/domain-models/contractAndRates/parseDomainData.test.ts
@@ -88,15 +88,34 @@ describe('parseDomainData', () => {
         )
     })
     describe('parseDraftContractRevision', () => {
+        it('cant parse valid contract revision with no errors', () => {
+            const contractRevision =
+                createContractRevision() as DraftContractRevisionTableWithRelations
+            expect(
+                parseDraftContractRevision(contractRevision)
+            ).not.toBeInstanceOf(Error)
+        })
         const draftContractRevisionsWithInvalidData: {
             revision: DraftContractRevisionTableWithRelations
             testDescription: string
         }[] = [
             {
                 revision: createContractRevision({
-                    programIDs: undefined,
+                    submissionType: undefined,
+                }) as DraftContractRevisionTableWithRelations,
+                testDescription: 'invalid submissionType',
+            },
+            {
+                revision: createContractRevision({
+                    submissionDescription: undefined,
+                }) as DraftContractRevisionTableWithRelations,
+                testDescription: 'invalid submissionDescription',
+            },
+            {
+                revision: createContractRevision({
+                    contractType: undefined,
                 }) as DraftContractRevisionTableWithRelations,
-                testDescription: 'invalid programIDs',
+                testDescription: 'invalid contractType',
             },
             {
                 revision: createContractRevision({