remove mccrs-record-number flag, delete button and blank entry valida…

…tion
Enterprise-CMCS · Oct 25, 2023 · 7130786 · 7130786
1 parent ba5e2e4
commit 7130786
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 93 deletions.
diff --git a/services/app-web/src/common-code/featureFlags/flags.ts b/services/app-web/src/common-code/featureFlags/flags.ts
@@ -41,13 +41,6 @@ const featureFlags = {
         flag: 'cms-questions',
         defaultValue: false,
     },
-    /**
-     * Enables CMS users to add, view, edit and delete MC-CRS record numbers
-     */
-    MCCRS_RECORD_NUMBER: {
-        flag: 'mccrs-record-number',
-        defaultValue: false,
-    },
     /**
      * Enables packages with shared rates dropdown on rate details page. This was an early version of rates across subs functionality.
      */

diff --git a/services/app-web/src/pages/App/AppRoutes.tsx b/services/app-web/src/pages/App/AppRoutes.tsx
@@ -160,11 +160,6 @@ const CMSUserRoutes = ({
         featureFlags.RATE_REVIEWS_DASHBOARD.defaultValue
     )
 
-    const showMCCRSRecordNumber = ldClient?.variation(
-        featureFlags.MCCRS_RECORD_NUMBER.flag,
-        featureFlags.MCCRS_RECORD_NUMBER.defaultValue
-    )
-
     return (
         <AuthenticatedRouteWrapper authMode={authMode} setAlert={setAlert}>
             <Routes>
@@ -212,12 +207,12 @@ const CMSUserRoutes = ({
                         path={RoutesRecord.SUBMISSIONS_SUMMARY}
                         element={<SubmissionSummary />}
                     />
-                    {showMCCRSRecordNumber && (
+                    {
                         <Route
                             path={RoutesRecord.SUBMISSIONS_MCCRSID}
                             element={<MccrsId />}
                         />
-                    )}
+                    }
                 </Route>
 
                 <Route

diff --git a/services/app-web/src/pages/MccrsId/MccrsId.module.scss b/services/app-web/src/pages/MccrsId/MccrsId.module.scss
@@ -79,22 +79,12 @@ div[class^='usa-hint'] span {
 } 
 
 ul[class^='usa-button-group'] {
-    justify-content: space-between;
+    justify-content: end;
     li[class^='usa-button-group__item'] {
         margin-top: 0;
         button {
             margin-top: 16px;
             margin-bottom: 44px;
-        }
-        &:first-of-type {
-            button[class^='usa-button'] {
-                display: none; 
-                visibility: hidden;
-                color: $theme-color-error-darker;
-                box-shadow: inset 0 0 0 2px $theme-color-error-darker;
-            }
-        }
-        &:last-of-type {
             margin-right: .25rem;
         }
     }

diff --git a/services/app-web/src/pages/MccrsId/MccrsId.test.tsx b/services/app-web/src/pages/MccrsId/MccrsId.test.tsx
@@ -8,16 +8,10 @@ import {
     fetchStateHealthPlanPackageWithQuestionsMockSuccess,
     mockValidCMSUser,
 } from '../../testHelpers/apolloMocks'
-import {
-    ldUseClientSpy,
-    renderWithProviders,
-} from '../../testHelpers/jestHelpers'
+import { renderWithProviders } from '../../testHelpers/jestHelpers'
 import { MccrsId } from './MccrsId'
 
 describe('MCCRSID', () => {
-    beforeEach(() => {
-        ldUseClientSpy({ 'mccrs-record-number': true })
-    })
     afterEach(() => {
         jest.resetAllMocks()
     })
@@ -89,47 +83,6 @@ describe('MCCRSID', () => {
         expect(await screen.findByTestId('textInput')).toBeInTheDocument()
     })
 
-    it('cannot continue without providing a MCCRS ID', async () => {
-        renderWithProviders(
-            <Routes>
-                <Route element={<SubmissionSideNav />}>
-                    <Route
-                        path={RoutesRecord.SUBMISSIONS_MCCRSID}
-                        element={<MccrsId />}
-                    />
-                </Route>
-            </Routes>,
-            {
-                apolloProvider: {
-                    mocks: [
-                        fetchCurrentUserMock({
-                            user: mockValidCMSUser(),
-                            statusCode: 200,
-                        }),
-                        fetchStateHealthPlanPackageWithQuestionsMockSuccess({
-                            id: '15',
-                        }),
-                    ],
-                },
-                routerProvider: {
-                    route: '/submissions/15/mccrs-record-number',
-                },
-            }
-        )
-        const continueButton = await screen.findByRole('button', {
-            name: 'Save MC-CRS number',
-        })
-        continueButton.click()
-        await waitFor(() => {
-            expect(
-                screen.getAllByText(
-                    'You must enter a record number or delete this field.'
-                )
-            ).toHaveLength(1)
-            expect(continueButton).toHaveAttribute('aria-disabled', 'true')
-        })
-    })
-
     it('cannot continue with MCCRS ID with non number input', async () => {
         renderWithProviders(
             <Routes>

diff --git a/services/app-web/src/pages/MccrsId/MccrsId.tsx b/services/app-web/src/pages/MccrsId/MccrsId.tsx
@@ -144,16 +144,6 @@ export const MccrsId = (): React.ReactElement => {
                                 />
                             </fieldset>
                             <ButtonGroup type="default">
-                                <ActionButton
-                                    type="button"
-                                    variant="outline"
-                                    secondary
-                                    data-testid="page-actions-left-secondary"
-                                    onClick={() => console.info('delete')}
-                                >
-                                    Delete Number
-                                </ActionButton>
-
                                 <ActionButton
                                     type="submit"
                                     variant="default"

diff --git a/services/app-web/src/pages/MccrsId/MccrsIdSchema.ts b/services/app-web/src/pages/MccrsId/MccrsIdSchema.ts
@@ -2,8 +2,6 @@ import * as Yup from 'yup'
 
 export const MccrsIdFormSchema = () => {
     return Yup.object().shape({
-        mccrsId: Yup.number()
-            .required('You must enter a record number or delete this field.')
-            .typeError('You must enter a number'),
+        mccrsId: Yup.number().typeError('You must enter a number'),
     })
 }
diff --git a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.test.tsx b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.test.tsx
@@ -27,7 +27,6 @@ import { testS3Client } from '../../testHelpers/s3Helpers'
 describe('SubmissionSummary', () => {
     beforeEach(() => {
         ldUseClientSpy({ 'cms-questions': false })
-        ldUseClientSpy({ 'mccrs-record-number': true })
     })
     afterEach(() => {
         jest.resetAllMocks()

diff --git a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx
@@ -68,11 +68,6 @@ export const SubmissionSummary = (): React.ReactElement => {
         featureFlags.CMS_QUESTIONS.defaultValue
     )
 
-    const showMCCRSRecordNumber = ldClient?.variation(
-        featureFlags.MCCRS_RECORD_NUMBER.flag,
-        featureFlags.MCCRS_RECORD_NUMBER.defaultValue
-    )
-
     const { pkg, currentRevision, packageData, user, documentDates } =
         useOutletContext<SideNavOutletContextType>()
 
@@ -167,7 +162,7 @@ export const SubmissionSummary = (): React.ReactElement => {
 
                 <SubmissionTypeSummarySection
                     subHeaderComponent={
-                        isCMSUser && showMCCRSRecordNumber ? (
+                        isCMSUser ? (
                             <div className={styles.subHeader}>
                                 {pkg.mccrsID && (
                                     <span>