fix tests, fix bug

Enterprise-CMCS · Nov 1, 2023 · d691597 · d691597
1 parent 278cdec
commit d691597
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 20 deletions.
diff --git a/services/app-api/src/resolvers/questionResponse/createQuestion.test.ts b/services/app-api/src/resolvers/questionResponse/createQuestion.test.ts
@@ -13,20 +13,25 @@ import {
     createDBUsersWithFullData,
     testCMSUser,
 } from '../../testHelpers/userHelpers'
+import { testLDService } from '../../testHelpers/launchDarklyHelpers'
 
 describe('createQuestion', () => {
+    const mockLDService = testLDService({ ['rates-db-refactor']: true })
     const cmsUser = testCMSUser()
     beforeAll(async () => {
         //Inserting a new CMS user, with division assigned, in postgres in order to create the question to user relationship.
         await createDBUsersWithFullData([cmsUser])
     })
 
     it('returns question data after creation', async () => {
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const cmsServer = await constructTestPostgresServer({
             context: {
                 user: cmsUser,
             },
+            ldService: mockLDService,
         })
 
         const submittedPkg = await createAndSubmitTestHealthPlanPackage(
@@ -41,7 +46,7 @@ describe('createQuestion', () => {
         expect(createdQuestion.question).toEqual(
             expect.objectContaining({
                 id: expect.any(String),
-                pkgID: submittedPkg.id,
+                contractID: submittedPkg.id,
                 division: 'DMCO',
                 documents: [
                     {
@@ -54,11 +59,14 @@ describe('createQuestion', () => {
         )
     })
     it('allows question creation on UNLOCKED and RESUBMITTED package', async () => {
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const cmsServer = await constructTestPostgresServer({
             context: {
                 user: cmsUser,
             },
+            ldService: mockLDService,
         })
 
         const submittedPkg = await createAndSubmitTestHealthPlanPackage(
@@ -104,7 +112,7 @@ describe('createQuestion', () => {
                             node: expect.objectContaining({
                                 id: expect.any(String),
                                 createdAt: expect.any(Date),
-                                pkgID: submittedPkg.id,
+                                contractID: submittedPkg.id,
                                 division: 'DMCO',
                                 documents: [
                                     {
@@ -119,7 +127,7 @@ describe('createQuestion', () => {
                             node: expect.objectContaining({
                                 id: expect.any(String),
                                 createdAt: expect.any(Date),
-                                pkgID: submittedPkg.id,
+                                contractID: submittedPkg.id,
                                 division: 'DMCO',
                                 documents: [
                                     {
@@ -144,11 +152,14 @@ describe('createQuestion', () => {
         )
     })
     it('returns an error package status is DRAFT', async () => {
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const cmsServer = await constructTestPostgresServer({
             context: {
                 user: cmsUser,
             },
+            ldService: mockLDService,
         })
 
         const draftPkg = await createTestHealthPlanPackage(stateServer)
@@ -157,7 +168,7 @@ describe('createQuestion', () => {
             query: CREATE_QUESTION,
             variables: {
                 input: {
-                    pkgID: draftPkg.id,
+                    contractID: draftPkg.id,
                     documents: [
                         {
                             name: 'Test Question',
@@ -175,7 +186,9 @@ describe('createQuestion', () => {
         )
     })
     it('returns an error if a state user attempts to create a question for a package', async () => {
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const submittedPkg = await createAndSubmitTestHealthPlanPackage(
             stateServer
         )
@@ -184,7 +197,7 @@ describe('createQuestion', () => {
             query: CREATE_QUESTION,
             variables: {
                 input: {
-                    pkgID: submittedPkg.id,
+                    contractID: submittedPkg.id,
                     documents: [
                         {
                             name: 'Test Question',
@@ -202,11 +215,14 @@ describe('createQuestion', () => {
         )
     })
     it('returns error on invalid package id', async () => {
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const cmsServer = await constructTestPostgresServer({
             context: {
                 user: cmsUser,
             },
+            ldService: mockLDService,
         })
 
         await createAndSubmitTestHealthPlanPackage(stateServer)
@@ -215,7 +231,7 @@ describe('createQuestion', () => {
             query: CREATE_QUESTION,
             variables: {
                 input: {
-                    pkgID: 'invalid-pkg-id',
+                    contractID: 'invalid-pkg-id',
                     documents: [
                         {
                             name: 'Test Question',
@@ -229,19 +245,22 @@ describe('createQuestion', () => {
         expect(createdQuestion.errors).toBeDefined()
         expect(assertAnErrorCode(createdQuestion)).toBe('NOT_FOUND')
         expect(assertAnError(createdQuestion).message).toBe(
-            `Issue finding a package with id invalid-pkg-id. Message: Package with id invalid-pkg-id does not exist`
+            `Package with id invalid-pkg-id does not exist`
         )
     })
     it('returns error when CMS user division is unassigned', async () => {
         const cmsUserWithNoDivision = testCMSUser({
             divisionAssignment: undefined,
         })
         await createDBUsersWithFullData([cmsUserWithNoDivision])
-        const stateServer = await constructTestPostgresServer()
+        const stateServer = await constructTestPostgresServer({
+            ldService: mockLDService,
+        })
         const cmsServer = await constructTestPostgresServer({
             context: {
                 user: cmsUserWithNoDivision,
             },
+            ldService: mockLDService,
         })
 
         await createAndSubmitTestHealthPlanPackage(stateServer)
@@ -250,7 +269,7 @@ describe('createQuestion', () => {
             query: CREATE_QUESTION,
             variables: {
                 input: {
-                    pkgID: 'invalid-pkg-id',
+                    contractID: 'invalid-pkg-id',
                     documents: [
                         {
                             name: 'Test Question',

diff --git a/services/app-api/src/resolvers/questionResponse/createQuestion.ts b/services/app-api/src/resolvers/questionResponse/createQuestion.ts
@@ -69,12 +69,8 @@ export function createQuestionResolver(
             })
         }
 
-        // Return error if package status is DRAFT
-        // TODO we should have a helper for this
-        if (
-            contractResult.revisions.length === 1 &&
-            contractResult.revisions[0].submitInfo === undefined
-        ) {
+        // Return error if package status is DRAFT, contract will have no submitted revisions
+        if (contractResult.revisions.length === 0) {
             const errMessage = `Issue creating question for health plan package. Message: Cannot create question for health plan package in DRAFT status`
             logError('createQuestion', errMessage)
             setErrorAttributesOnActiveSpan(errMessage, span)