Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR-3569: Prod: User reported error in downloading zip files #1846

Merged

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Aug 1, 2023

Summary

MR-3569

Changed the expiration for the document URLs to 1 hour. I was still able to download files past 15 minutes.

This is the error after an hour (Using a different file)

Related issues

Screenshots

Test cases covered

QA guidance

If you keep opening the same file, it will work past 1 hour. Not sure why, maybe it's cached? But below are instructions on how to correctly test the expiration time.

For testing this issue:

  1. Open a submission, but do not click on any file.
  2. Wait 45 minutes or right before an hour.
  3. Click on any file to download, and it should still work
  4. Wait past 1 hour and click on A DIFFERENT file and it should open a new tab to an error.

Copy link
Contributor

@mojotalantikite mojotalantikite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed -- download link works fine before an hour, access denied after an hour.

@JasonLin0991 JasonLin0991 merged commit 2a2c7e7 into main Aug 7, 2023
27 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-MR-3569-Prod-reported-error-in-downloading-zip-files branch August 7, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants