MR-3569: Prod: User reported error in downloading zip files #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojotalantikite
approved these changes
Aug 4, 2023
JasonLin0991
deleted the
jl-MR-3569-Prod-reported-error-in-downloading-zip-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MR-3569
Changed the expiration for the document URLs to 1 hour. I was still able to download files past 15 minutes.
This is the error after an hour (Using a different file)
Related issues
Screenshots
Test cases covered
QA guidance
If you keep opening the same file, it will work past 1 hour. Not sure why, maybe it's cached? But below are instructions on how to correctly test the expiration time.
For testing this issue: