Insert Rate #1865
Merged
Insert Rate #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
approved these changes
Aug 8, 2023
| revisionFormData: z.string(), | ||
| createdAt: z.date(), | ||
| updatedAt: z.date(), | ||
| revisionFormData: rateFormDataSchema, |
There was a problem hiding this comment.
Let's also change contractRevisionSchema.formData to contractRevisionSchema.revisionFormData. Just to keep revision fields similar.
| revisions: allRevisions.reverse(), | ||
| } | ||
|
|
||
| return finalRate |
There was a problem hiding this comment.
Will be doing the validation using Zod in a later ticket? Makes sense to me if we are, but just confirming here.
| revisionFormData: rr.rateRevision.name, | ||
| }) | ||
| ), | ||
| rateRevisions: [], |
There was a problem hiding this comment.
Is rateRevisions still needed here? It could be confusing that these contractRevisions have an empty array of rateRevisions. This empty string could also mean no relationships in the DB. I rather we are explicit and not include it in finalRate.
| id: rate.id, | ||
| status: 'DRAFT', |
There was a problem hiding this comment.
I think you mentioned using getContractStatus here instead of hard coding the status.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I started from scratch and copied over rate work from Hana's branch to get insertRate working.
There's still a decent amount of type cleanup to work through but this is working
Related issues
Screenshots
Test cases covered
QA guidance