Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR-3405: Reference help desk email in system notification emails #1867

Merged
merged 10 commits into from
Aug 15, 2023
Merged

MR-3405: Reference help desk email in system notification emails #1867

merged 10 commits into from
Aug 15, 2023

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Aug 8, 2023 •
edited
Loading

Summary

MR-3405

  • References the help desk email in New submission state emails. Notice when you reply to the email, the help desk email is now in the recipient instead of mc-review-qa@truss.works.
  • Removed references to MC review dev team email
  • Updated Email settings page support tab with help desk email.

Related issues

Screenshots

Test cases covered

QA guidance

@JasonLin0991 JasonLin0991 marked this pull request as ready for review August 9, 2023 18:13
macrael
macrael approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, are we still using the devTeamHelpAddress anywhere?

@JasonLin0991
Copy link
Contributor Author

JasonLin0991 commented Aug 10, 2023 •
edited
Loading

Looks good, are we still using the devTeamHelpAddress anywhere?

Doesn't look like it. Would we ever use this email again? Should I remove it from the backend and the store?

@haworku
Copy link
Contributor

haworku commented Aug 10, 2023 •
edited
Loading

@JasonLin0991 oh! Yes please remove from everywhere. dev team is no longer support/help at all. Please also update all docs that explain configuration Configuration.md in github and https://github.com/Enterprise-CMCS/managed-care-review/blob/main/docs/Configuration.md#email-configuration those were created to avoid confusion around what the variables are and why they exist.

haworku
haworku approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. thanks for catching the settings page aspect also.

@JasonLin0991 JasonLin0991 merged commit 0312ba8 into main Aug 15, 2023
27 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-mr-3405-reference-help-desk-email-in-system-notification-emails branch August 15, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macrael macrael macrael approved these changes

@haworku haworku haworku approved these changes

@rswerve rswerve Awaiting requested review from rswerve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonLin0991 @haworku @macrael