Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR-3405: Reference help desk email in system notification emails #1867

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Aug 8, 2023

Summary

MR-3405

  • References the help desk email in New submission state emails. Notice when you reply to the email, the help desk email is now in the recipient instead of mc-review-qa@truss.works.
  • Removed references to MC review dev team email
  • Updated Email settings page support tab with help desk email.

Related issues

Screenshots

Test cases covered

QA guidance

Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, are we still using the devTeamHelpAddress anywhere?

@JasonLin0991
Copy link
Contributor Author

JasonLin0991 commented Aug 10, 2023

Looks good, are we still using the devTeamHelpAddress anywhere?

Doesn't look like it. Would we ever use this email again? Should I remove it from the backend and the store?

@haworku
Copy link
Contributor

haworku commented Aug 10, 2023

@JasonLin0991 oh! Yes please remove from everywhere. dev team is no longer support/help at all. Please also update all docs that explain configuration Configuration.md in github and https://github.com/Enterprise-CMCS/managed-care-review/blob/main/docs/Configuration.md#email-configuration those were created to avoid confusion around what the variables are and why they exist.

Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. thanks for catching the settings page aspect also.

@JasonLin0991 JasonLin0991 merged commit 0312ba8 into main Aug 15, 2023
27 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-mr-3405-reference-help-desk-email-in-system-notification-emails branch August 15, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants