Consolidate contract and rate types #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
approved these changes
Aug 14, 2023
| @@ -74,6 +74,11 @@ function convertContractToUnlockedHealthPlanPackage( | |||
| ): HealthPlanPackageType | Error { | |||
| console.info('Attempting to convert contract to health plan package') | |||
|
|
|||
| // Since drafts come in separate on the Contract type, we push it onto the revisions before converting below | |||
| if (contract.draftRevision) { | |||
| contract.revisions.unshift(contract.draftRevision) | |||
There was a problem hiding this comment.
🔴 should we do anything else to verify that the first revision is indeed a draft here or can we be confident?
There was a problem hiding this comment.
I think we're good here, a draft should be a draft if we put it on draftRevision
| if (!rateRev.submitInfo) { | ||
| if (draftRevision) { | ||
| return new Error( | ||
| 'PROGRAMMING ERROR: a contract may not have multiple drafts simultaneously. ID: ' + |
There was a problem hiding this comment.
Suggested change
| 'PROGRAMMING ERROR: a contract may not have multiple drafts simultaneously. ID: ' + | |
| 'PROGRAMMING ERROR: a rate may not have multiple drafts simultaneously. ID: ' + |
| const rateRevisions = rate.revisions | ||
| let draftRevision: RateRevisionWithContractsType | undefined = undefined | ||
| for (const rateRev of rateRevisions) { | ||
| // no drafts allowed |
There was a problem hiding this comment.
Suggested change
| // no drafts allowed | |
| // We have already set the draft revision aside, all ordered revisions here should be submitted |
| draftContracts: DraftContractsTable[] | ||
| ): ContractRevisionType[] { | ||
| return draftContracts.map((dc) => | ||
| contractRevisionToDomainModel(dc.revisions[0]) |
There was a problem hiding this comment.
Nice this is good - I like this way of making sure we only grab the first by putting it just at the level of the domain transform function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all the Rate types to match the Contract types and gets rid of the separate Draft types for both.
All of our contract and rate functions can now return this full table type.
I think some of the files could be consolidated now but I messed it up on my first try so I scrapped that for today.
Related issues
Screenshots
Test cases covered
QA guidance