Skip ahead to re-run only Cypress #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojotalantikite
changed the title
macrael
approved these changes
Aug 22, 2023
| if (commitMessage.includes('ci-force-run')) { | ||
| core.setOutput('changed-services', deployAllServices) | ||
| return | ||
| } | ||
|
|
||
| // force just a cypress re-run | ||
| if (commitMessage.includes('cypress re-run')) { |
There was a problem hiding this comment.
I didn't know about ci-force-run, where would be a good place to document these CI incantations?
There was a problem hiding this comment.
The force-ci-run is in the main Readme, but it looks like it's a little buried and hard to pick out. I just pushed up a change that documents the new cypress re-run and breaks those docs out into a section so it's easier to run across!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug -- or really, a lack of functionality -- with cypress re-runs when using the GHA
re-run failed jobsoption, which is a known issue. If you're using a parallelized container build in GHA CI (as we do) and a container or two has a failed spec, choosing to use the GHAre-run failed jobsfeature will load all of the Cypress tests onto that container that has failed and try to re-run everything there. This is unexpected, as I think people assume only the failed specs and other tests that were allocated to the failed container will re-run. Since we have a 25 minute timeout on Cypress runs, and we're running the entire test suite on a fraction of the containers in this scenario, we'll always hit that timeout and get a failed run.I've added a bit of a hack-y workaround here until a re-run feature is taken on by the Cypress team. Basically, if the CI skipping script sees a commit message with
cypress re-runin it, it'll skip past all the infra and app deploy stages and bring us right to the Cypress run stage. It's not as good as re-running only the failed test specs, but I guess it's better than having to wait for an entire CI deploy due to a flaky test.This also changes the ID for cypress runs to help us correlate the run in Cypress dashboard to the GHA run a little easier.
Related issues
https://qmacbis.atlassian.net/browse/MR-3225