Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MR-3334] Update Guidance Text for Uploading Documents #1902

Merged
merged 17 commits into from
Sep 7, 2023

Conversation

pearl-truss
Copy link
Contributor

@pearl-truss pearl-truss commented Aug 31, 2023

Summary

MR-3334

This PR contains a handful of small tweaks to the upload sections of the Rate Details, Contract Details and Supporting Document pages

Rate Details Changes

Designs

  • Changed label for file upload: Upload rate certification -> Upload one rate certification document
  • Changed file upload hint text: Upload one rate certification only. -> Upload only one rate certification document
  • Preserved logic of displaying 'Additional rates can be added later.' vs 'Additional rates and supporting documents can be added later.' depending on the supporting docs by rate feature flag
  • Changed file type help text: This input only accepts PDF, CSV, DOC, DOCX,XLS, XLSX, XLSM files. -> This input only accepts one file in PDF, DOC, or DOCX format.
Contract Details Changes

Designs

  • Moved the document definitions link to above the help text
  • Added help text: Supporting documents can be added later. If you have additional contract actions, you must submit them in a separate submission.
  • Removed XLSM for supported file type text
Supporting Documents Changes

Designs

  • Changed file upload label: Upload any additional supporting documents -> Upload contract-supporting documents
  • Added help text: Upload any supporting documents related to the contract.
  • Removed XLSM for supported file type text

Screenshots

Rates Details
Screenshot 2023-08-31 at 3 53 55 PM

Contract Details
Screenshot 2023-08-31 at 3 53 45 PM

Supporting Documents
Screenshot 2023-08-31 at 3 59 10 PM

Test cases covered

QA guidance

@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 19:20 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss temporarily deployed to dev September 1, 2023 20:12 — with GitHub Actions Inactive
@pearl-truss pearl-truss marked this pull request as ready for review September 5, 2023 17:33
@pearl-truss pearl-truss changed the title DRAFT [MR-3334] Update Guidance Text for Uploading Documents [MR-3334] Update Guidance Text for Uploading Documents Sep 5, 2023
@pearl-truss pearl-truss self-assigned this Sep 5, 2023
This input only accepts PDF, CSV, DOC, DOCX,
XLS, XLSX, XLSM files.
This input only accepts one file in PDF, DOC, or
DOCX format.
</span>
</span>
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to change the constant passed into accept prop of the FileUpload. This is currently set to allow PDF, CSV, DOC, DOCX, XLS, XLSX, XLSM files. We should make a new constant in the same constants.ts file that would be for rate certification documents.

The constants file is in services/app-web/src/components/FileUpload/constants.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look Jason, I updated the PR accordingly

Copy link
Contributor

@JasonLin0991 JasonLin0991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes! Great job 🙌!

@pearl-truss pearl-truss merged commit a391db4 into main Sep 7, 2023
27 checks passed
@pearl-truss pearl-truss deleted the mr-3334-update-upload-content branch September 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants