-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MR-3576] Add required and optional labels to fields #1923
[MR-3576] Add required and optional labels to fields #1923
Conversation
@pearl-truss Is it possible to just use the input's required attribute to determine the label? I'm wondering if the |
Maybe I'm mistaken (I'll clarify with design) but what I saw on figma showed the labels just on the contract and rate pages. And I agree that if it is for every label than |
nal label to the shared package rates fields
* add and use theme color for hints * start adding required labels * add inline required labels where possible * add styling to inline required label * Add required lable to actuary fields * Add required label to file uploads * Add required label to FieldYesNo component * conditionally display required or optional label depending on whats passed in * pass required prop to contacts * include required/optional label for textarea * add new styles for textarea * add optional label to supporting documents upload field * update so that required/optional labels are on the contacts and rate details page * update styling * add correct file types for supporting rate docs * clean up single rate cert file * ensure file upload only shows required/optional contract and rate pages * remove the showRequiredOptionalLabel prop * add required labels to the submission type page * add required/optional labels to the Contacts page * cypress re-run * Add required/optio nal label to the shared package rates fields * fix unit test
Summary
This PR adds required or optional labels to fields based on the designs referenced in the ticket
showRequiredOptionalLabel
was created to conditionally show the required/optional label given that inputs on the non contract and rate details pages shouldn't have this label displayedFieldTextarea
,FIeldYesNo
, andFileUpload
usesaria-required
Related issues
https://qmacbis.atlassian.net/browse/MR-3576
Screenshots
Test cases covered
QA guidance