MR-2923 Add tabs and empty rates dashboard #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
requested review from
pearl-truss,
JasonLin0991 and
macrael
and removed request for
pearl-truss and
JasonLin0991
pearl-truss
approved these changes
Sep 21, 2023
| GRAPHQL_EXPLORER: '/dev/graphql-explorer', | ||
| HELP: '/help', | ||
| REPORTS: '/reports', | ||
| SETTINGS: '/settings', | ||
| SUBMISSIONS: '/submissions', | ||
| SUBMISSIONS_NEW: '/submissions/new', | ||
| SUBMISSIONS_FORM: '/submissions/:id/edit/*', | ||
| SUBMISSIONS_EDIT_TOP_LEVEL: '/submissions/:id/edit/*', |
There was a problem hiding this comment.
Question: what does top level refer to?
There was a problem hiding this comment.
I threw a description in the comment _"The suffix "TOP_LEVEL" mean this route contains an global asterisk has several descendant routes it covers" basically its a glob route and has several descendant routes it covers. Let me know if a different naming is clearer or what you think of this description. I was trying to think how to name this route more precisely because I realized its quite different than other routes in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get tabs, routes, and empty state for dashboard working. Add tests.
Related issues
https://qmacbis.atlassian.net/browse/MCR-2559
Screenshots
Test cases covered
QA guidance