-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MR-2923 Add tabs and empty rates dashboard #1932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
GRAPHQL_EXPLORER: '/dev/graphql-explorer', | ||
HELP: '/help', | ||
REPORTS: '/reports', | ||
SETTINGS: '/settings', | ||
SUBMISSIONS: '/submissions', | ||
SUBMISSIONS_NEW: '/submissions/new', | ||
SUBMISSIONS_FORM: '/submissions/:id/edit/*', | ||
SUBMISSIONS_EDIT_TOP_LEVEL: '/submissions/:id/edit/*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: what does top level refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I threw a description in the comment _"The suffix "TOP_LEVEL" mean this route contains an global asterisk has several descendant routes it covers" basically its a glob route and has several descendant routes it covers. Let me know if a different naming is clearer or what you think of this description. I was trying to think how to name this route more precisely because I realized its quite different than other routes in the list.
Summary
Get tabs, routes, and empty state for dashboard working. Add tests.
Related issues
https://qmacbis.atlassian.net/browse/MCR-2559
Screenshots
Test cases covered
QA guidance