Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MR-3576] Design and accessibility tweaks to required and optional labels #1937

Merged
merged 4 commits into from
Sep 26, 2023
Merged

[MR-3576] Design and accessibility tweaks to required and optional labels #1937

merged 4 commits into from
Sep 26, 2023

Conversation

pearl-truss
Copy link
Contributor

@pearl-truss pearl-truss commented Sep 21, 2023 •
edited
Loading

Summary

This PR updates the following:

  • Adjust the margin on the Submission type, Contract and Rate details pages so that there's only the 32px padding applied to the form container
  • On the Submission Type page ensure JAWS reads out that the Submission description field is required
  • On the Rate details page: ensure JAWS doesn't skip the Rate certification type label and gets rid of the redundant "Required group, required." announcement
  • On the Rate details page ensure that JAWS calls out the Certifying actuary fields as required

This PR doesn't include the following

  • Changes the order of announcement on the rate and contract pages between the labels and upload links. I'll wait for confirmation from Design and Hana if there's a preference. Same with the optional call out on the supporting docs page

Related issues

https://qmacbis.atlassian.net/browse/MCR-1790

QA

  • Sign in as a state user and navigate the app using a screen reader. All required labels should be read out

Screenshots

Screenshot 2023-09-21 at 11 26 25 AM Screenshot 2023-09-21 at 11 27 10 AM Screenshot 2023-09-21 at 11 27 01 AM

@pearl-truss pearl-truss changed the title Mr 3576 add required and optional labels to fields design fix [MR-3576] Design and accessibility tweaks to required and optional labels Sep 21, 2023
@pearl-truss pearl-truss marked this pull request as ready for review September 25, 2023 16:47
@pearl-truss pearl-truss merged commit efa3e5f into main Sep 26, 2023
27 checks passed
@pearl-truss pearl-truss deleted the mr-3576-add-required-and-optional-labels-to-fields-design-fix branch September 26, 2023 18:08
haworku pushed a commit that referenced this pull request Oct 16, 2023
@pearl-truss @haworku
[MR-3576] Design and accessibility tweaks to required and optional la…
87a5419 
…bels (#1937)

* fix a11y on rates details page

* fix a11y on rates details page

* add note attribute to fieldtextarea

* adjust margin for the contract and submission type pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haworku haworku haworku approved these changes

@macrael macrael Awaiting requested review from macrael

@JasonLin0991 JasonLin0991 Awaiting requested review from JasonLin0991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pearl-truss @haworku