MR-2364: Dealt with packages with shared rates in the current UI #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanlding of no rate programs.
…mainModel. Update conversion functions to return error types.
…lue with formData id to pkg id.
…g errors in tests if programs are not found.
…shared-rates # Conflicts: # services/app-web/src/pages/StateSubmission/StateSubmissionForm.tsx # services/app-web/src/pages/SubmissionSideNav/SubmissionSideNav.tsx
JasonLin0991
requested review from
haworku,
macrael,
pearl-truss and
mojotalantikite
and removed request for
haworku
haworku
reviewed
Oct 2, 2023
| contractsWithSharedRateRevision: { | ||
| include: { | ||
| revisions: { | ||
| take: 1, |
There was a problem hiding this comment.
This looks fine to me based on the prisma table - to answer your question from the PR description. I think returning just latest rev for the linked contract makes sense.
I think it could be possible then we could display too early the updated programs from a rate that is unlocked and being edited by the state ...but I don't see a way around that since its a contract - rate revision relationship and not a contract revision - rate revision level relationship right now.
…shared-rates # Conflicts: # services/app-api/prisma/schema.prisma # services/app-api/src/postgres/contractAndRates/parseContractWithHistory.ts # services/app-api/src/postgres/contractAndRates/parseRateWithHistory.ts # services/app-api/src/postgres/contractAndRates/prismaSharedContractRateHelpers.ts # services/app-api/src/postgres/contractAndRates/updateDraftContractWithRates.ts # services/app-api/src/resolvers/healthPlanPackage/submitHealthPlanPackage.test.ts # services/app-api/src/resolvers/healthPlanPackage/unlockHealthPlanPackage.test.ts # services/app-api/src/resolvers/healthPlanPackage/updateHealthPlanFormData.test.ts # services/app-api/src/testHelpers/contractAndRates/contractHelpers.ts # services/app-api/src/testHelpers/contractAndRates/rateHelpers.ts
JasonLin0991
deleted the
jl-mr-2364-new-db-rates-model-packages-with-shared-rates
branch
macrael
approved these changes
Oct 2, 2023
| // We only care about the contract ID. PackageName is not in our DB, instead when converting DB data to domain | ||
| // data we are generating the package name. | ||
| const packagesWithSharedRateCerts = | ||
| hppRateFormData.packagesWithSharedRateCerts?.reduce( |
There was a problem hiding this comment.
interesting use of reduce, I feel like it might be clearer to chain a filter and a map, here
haworku
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Update packagesWithSharedRateCerts to contractsWithSharedRateRevision. * Refactor packageName parameters to only accept what is used and move hanlding of no rate programs. * Add real packagesWithSharedRateCerts data from db to rateFormDataToDomainModel. Update conversion functions to return error types. * Refactor variable sub with pkg for less confusion. Replace setting value with formData id to pkg id. * Replace using getProgramsFromState with findStatePrograms and throwing errors in tests if programs are not found. * Fix imports * Update contractsWithSharedRateRevision * Update tests for packages with shared rate certs. * cypress re-run * cypress re-run * Fix some merging stuff. * cypress re-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MR-2364
packagesWithSharedRateCertstocontractsWithSharedRateRevision.ContractTableandRateRevisionTable.SharedRateCertificationsjoin table.includeDraftRatesandsubincludeUpdateInfoin the prisma helpers. AddedcontractsWithSharedRateRevisionthat includes only the latest contract revision.createdAtwith the assumption that we don't care if its draft or submitted.updateDraftContractWithRatesjust get an array of the contract ids andconnectwhen creating a rate andsetwhen updating. using set here because we are only updating the relationship, no other complexity here unlike updating the rate revisions.rateFormDataToDomainModelfunction now convertscontractsWithSharedRateRevisionfrom our DB to the domain modelpackagesWithSharedRateCerts.contractsWithSharedRateRevisionand generates thepackageNamefor each item.convertHealthPlanPackageRatesToDomainwill filter out anypackagesWithSharedRateCertsthat is missing apackageId. I don't think it will ever happen, but it's here to satisfy the type and in case we overlooked anything.getProgramsFromStateused in tests. This is basically duplicate offindStateProgramsbut instead of returning an error, it will return an empty string. Not good for tests, because we should not expect to find no programs for a valid state.PackagesWithSharedRates.tsxnow uses the package level id instead of the form data level.useParamswas causing an eslint error. Updated the types to get rid of the error.packageNamehas been refactored to take in arguments needed, instead of the entire package, for generating a name. Now, this can be used with new DB model contracts to generate the same name.generateRateNameMove defaulting to package programs into this function instead ofpackageName.Related issues
Screenshots
Test cases covered
QA guidance