MR-3545, MR-2370: Fix change history, add cypress tests, and turn on remaining API Unit tests #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
changed the title
JasonLin0991
changed the title
macrael
approved these changes
Oct 6, 2023
| @@ -124,7 +124,9 @@ describe('findContract', () => { | |||
| if (threeContract instanceof Error) { | |||
| throw threeContract | |||
| } | |||
| expect(threeContract.revisions).toHaveLength(4) | |||
There was a problem hiding this comment.
I'm very hesitant to lose the specific values in this test. This test was written to check that we get the expected number of revisions everywhere. I'd rather mark this test as skip or something than adapt it to work with the interim solution.
There was a problem hiding this comment.
Agree! Let's mark as skip.
haworku
pushed a commit
that referenced
this pull request
Oct 16, 2023
…remaining API Unit tests (#1959) * populating * keep incoming * remove default name. not sure why it's here? * use the right deploy script * move the migration into a func * return errors in prepopulate updateinfo * use error returns on insertContractId * return the error. no throws here for try/catch * clean up error messaging * move contract ops to migrateContract() * don't forget the associations error handling * the migrate results type * more tests * make it a helper func * rate revision test * check that we can get the migrated revision back * record the exception no need to return a packageId * fix test * more logging * clearAllMocks * doesnt' test anything now * some debug * keep track of migrations that did not complete * crashing on the user find * log out some stats * need to continue * just use the client we already get * remove some debug * all the contract ammendment info * get unlockInfoID * rate revision as well * testing file * fix up test some more * Adding test fixes and fixes from test * fixes in migrate. add DB reset at init. * use the prisma types in the test * finish adding contract docs * adds the rate docs * add another fake doc * contract/rate doc migration moved. * move join table work to the create phase * cleanup all the things * format on save? * enable remaining jest tests * fix up compare * Enable `rates-db-refactor` and `supporting-docs-by-rate` flag for cypress tests. * Skip Q&A tests, resolver not modified for refactor yet. * logging data objects out for compare * refactor comparison * more cleaning on test * fix the map to flatmap * fix up which we compare with * error check * Add extra test for change history order and count. * Remove rate history from contract history. * Add a check for which query to wait for. * Apply suggestions from code review Co-authored-by: Jason Lin <98117700+JasonLin0991@users.noreply.github.com> * some fixes to the migrator * fix ordering of contract revisions * update yarn.lock * Fix contractWithHistoryToDomainModel. * debug helper. * Update tests * Longer timeout looking for unlock button. * Update services/app-api/src/resolvers/healthPlanPackage/indexHealthPlanPackages.test.ts * Update services/app-api/src/resolvers/healthPlanPackage/indexHealthPlanPackages.test.ts * cypress re-run * add position to actuary contacts * Increase timeouts for more docs. * tests are suspiciously fixed * Skip tests for rate history. * test and fix how update contract with rates reads rateInfo.id * update migrators handling of submittedAt and unlocked rates * pass tx into findContractWithHistory. variable name changes for clarity. * Change setting id from revision id to rate id. * Fix tests for rate formData.id change. * connect related contract * fix tests proactively --------- Co-authored-by: Mazdak Atighi <maz@truss.works> Co-authored-by: Mojo Talantikite <mojo.talantikite@gmail.com> Co-authored-by: MacRae Linton <macrael@truss.works> Co-authored-by: MacRae Linton <55759+macrael@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MR-3545
MR-2370
The cause was duplicate contract revisions and Apollo Client Caching. See Apollo Client storing normalized docs. The duplicate contract revisions are made in contractWithHistoryToDomainModel when we construct a revision history for each change in rate revisions by creating a new contract revision with the same ID as the contract revision the rate change belongs to. When this data is returned to the frontend, Apollo cache sees duplicate contract revision IDs and merges the data.
See notes for more details on the investigation.
Changes:
contractWithHistoryToDomainModelremoved creating revision history for rate changes.unlockResubmits.specto test the order and count of the revision history.Related issues
Screenshots
Test cases covered
QA guidance