Fix rate history contract revisions #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
requested review from
macrael,
haworku and
pearl-truss
and removed request for
macrael
haworku
approved these changes
Oct 24, 2023
haworku
reviewed
Oct 24, 2023
| @@ -165,42 +166,58 @@ function rateWithHistoryToDomainModel( | |||
| ) | |||
| } | |||
|
|
|||
| // if it's from before this rate was submitted, it's there at the beginning. | |||
| // Finding the single earliest contract rev submitted right after rate rev submission date time. | |||
There was a problem hiding this comment.
This comment confuses me. Isn't this code finding multiple revs not just a single contract rev? Seems like we adding any contract rev that was submitted after rate rev to initialEntry.contractRevs with an array push.
Also why are keeping all this commented old code along? I think we can delete - its in version history.
There was a problem hiding this comment.
This is building the rate history using the rate.revisions in the type RateType.
- Since
rate.revisionsare all submitted rates, we need to attach the single contract revision that was submitted along with this rate to preserve the same submission data at that time. - We don't want future submission revisions of the same contract attached to it otherwise, this data would have future edits trickle down the revision history.
Let me know if that makes sense.
haworku
reviewed
Oct 24, 2023
| ) | ||
|
|
||
| // Each Revision needs a Reason, one of the contracts or revisions associated with it should have changed and why. | ||
| // Expect no draft revision | ||
| expect(latestRateTwoResubmit.draftRevision).toBeUndefined() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rate history revisions contract data.
This fix refactors
rateWithHistoryToDomainModelto only include the earliest submitted contract after the rate revision submissionsubmitInfo.updatedAt. Any proceeding contract revision with the samecontractIDwill be skipped.There was a discussion in DTBM 10.24.23 around the
Submission this rate was submitted withand if it should link to the latest submission summary or the submission summary that this rate was submitted with. Specifically, when a rate was removed, the summary is still linked to the latest submission summary.Related issues
Screenshots
Test cases covered
QA guidance