Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCR-3547] UI regression fix for MCCRS ID and State Contacts #2044

Merged
merged 12 commits into from
Nov 13, 2023
Merged

[MCR-3547] UI regression fix for MCCRS ID and State Contacts #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
89a586e
fix accessibilty issue with table caption being read out twice
pearl-truss Nov 2, 2023
d38ea88
fix issue with JAWS not calling out active tab
pearl-truss Nov 3, 2023
22ddbdd
cypress re-run
pearl-truss Nov 3, 2023
9a9b2c9
pr fixes
pearl-truss Nov 6, 2023
a82c3d4
cypress re-run
pearl-truss Nov 6, 2023
b47f858
cypress re-run
pearl-truss Nov 7, 2023
ce93578
Merge branch 'main' of https://github.com/Enterprise-CMCS/managed-car…
pearl-truss Nov 7, 2023
aea7f54
cypress re-run
pearl-truss Nov 7, 2023
954ad7c
rerun all jobs
pearl-truss Nov 7, 2023
e508a92
styling fix for UI regression
pearl-truss Nov 8, 2023
5bfd29a
Merge branch 'main' of https://github.com/Enterprise-CMCS/managed-car…
pearl-truss Nov 9, 2023
ae58c5e
ui fix for contact summary section
pearl-truss Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions ...src/components/SubmissionSummarySection/ContactsSummarySection/ContactsSummarySection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,23 +43,21 @@ export const ContactsSummarySection = ({
editNavigateTo={editNavigateTo}
/>

<GridContainer>
<GridContainer className="padding-left-0">
<Grid row>
<dl>
{submission.stateContacts.length > 0 ? (
submission.stateContacts.map(
(stateContact, index) => (
<Grid col={6} key={'statecontact_' + index}>
<DataDetail
id={'statecontact_' + index}
label={`Contact ${index + 1}`}
children={
<DataDetailContactField
contact={stateContact}
/>
}
/>
</Grid>
<DataDetail
id={'statecontact_' + index}
label={`Contact ${index + 1}`}
children={
<DataDetailContactField
contact={stateContact}
/>
}
/>
)
)
) : (
Expand Down
11 changes: 7 additions & 4 deletions services/app-web/src/pages/SubmissionSummary/SubmissionSummary.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,16 @@
margin-top: 17.5px;
span {
font-weight: bold;
a {
display: inline;
margin-top: 0;

&.mccrsID a {
display: inline-block;
margin-left: 5px;
margin-top: 0px;

}

}
.editLink {
a.editLink {
margin-top: 0;
}
}
Expand Down
2 changes: 1 addition & 1 deletion services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const SubmissionSummary = (): React.ReactElement => {
isCMSUser ? (
<div className={styles.subHeader}>
{pkg.mccrsID && (
<span>
<span className={styles.mccrsID}>
MC-CRS record number:
<Link
href={`https://mccrs.abtsites.com/Home/Index/${pkg.mccrsID}`}
Expand Down
Loading