Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR-3600 & MCR-3605: 438 Attestation #2050

Merged
merged 22 commits into from
Nov 15, 2023
Merged

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Nov 13, 2023

Summary

MCR-3600

  • Database and schema work
    • Add statutoryRegulatoryAttestation to ContractRevisionTable
    • Add statutoryRegulatoryAttestation to ContractFormDataType Domain types
    • Add statutoryRegulatoryAttestation to ContractInfo Protobuf schema
    • Add statutoryRegulatoryAttestation to UnlockedHealthPlanFormDataType and LockedHealthPlanFormDataType
    • Add statutoryRegulatoryAttestation to app-web/src/common-code/proto/healthPlanFormDataProto/zodSchemas.ts.
  • API Work
    • updateDraftContractWithRates and unlockContract handler to update statutoryRegulatoryAttestation
    • Update submitHealthPlanPackage resolver to validate on statutoryRegulatoryAttestation
    • Update contractFormDataToDomainModel and convertContractWithRatesToFormData for statutoryRegulatoryAttestation
    • Update test helpers and mocks
  • Frontend Work
    • Add feature flag 438-attestation
    • Update toDomain and toProtoBuffer for statutoryRegulatoryAttestation
    • Add attestation question and radio to Contract Details page
    • Display attestation question and answer on summary pages.
    • Fixed warnings on existing unit tests in ContractDetails.test.ts and ContractDetailsSummarySection.test.ts.
    • Mocked useLDClient.allFlags method for jest tests
    • Update helpers and mocks

MCR-3605

  • Add two links for the contract 438 attestation question on the Contract details page.
    Screenshot 2023-11-14 at 12 59 19 PM

Related issues

Screenshots

Test cases covered

  • Unit Tests

    • submitHealthPlanPackage.test.ts
      • 'errors when contract 4348 attestation question is undefined'
      • 'successfully submits when contract 4348 attestation question is valid'
        -ContractDetailsSummarySection.test.ts
      • 'displays correct contract 438 attestation yes and no text'
    • ContractDetails.test.ts
      • 'renders 438 attestation question without errors'
      • 'errors when continuing without answering 438 attestation question'
  • Cypress Tests:

    • fillOutBaseContractDetails and fillOutAmendmentToBaseContractDetails command. Added 438 attestation answer selection.
    • stubFeatureFlags command. Set 438-attestation flag to true on all tests.

QA guidance

@JasonLin0991 JasonLin0991 changed the title MCR-3600: 438 Attestation MCR-3600 & MCR-3605: 438 Attestation Nov 14, 2023
@@ -132,5 +134,8 @@ export const ContractDetailsFormSchema = (
modifiedNonRiskPaymentArrangements: yesNoError(
'modifiedNonRiskPaymentArrangements'
),
statutoryRegulatoryAttestation: activeFeatureFlags['438-attestation']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you move this key up in the object to be first in the list does it switch the error summary order? Where its located in the list of errors right now is confusing. If moving it up fixes things, please also add a comment to this file clarifying that order of keys matters in this file.
Screenshot 2023-11-14 at 2 00 50 PM

Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented with small tweaks, approving the rest! Good base to build on for the attestation reason explanation as well.

Co-authored-by: haworku <haworku@users.noreply.github.com>
@JasonLin0991 JasonLin0991 merged commit 0f56b70 into main Nov 15, 2023
27 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-mcr-3600-state-attestation branch November 15, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants