-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-3600 & MCR-3605: 438 Attestation #2050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
changed the title
MCR-3600: 438 Attestation
MCR-3600 & MCR-3605: 438 Attestation
Nov 14, 2023
haworku
reviewed
Nov 14, 2023
services/app-web/src/constants/statutoryRegulatoryAttestation.ts
Outdated
Show resolved
Hide resolved
haworku
reviewed
Nov 14, 2023
@@ -132,5 +134,8 @@ export const ContractDetailsFormSchema = ( | |||
modifiedNonRiskPaymentArrangements: yesNoError( | |||
'modifiedNonRiskPaymentArrangements' | |||
), | |||
statutoryRegulatoryAttestation: activeFeatureFlags['438-attestation'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haworku
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented with small tweaks, approving the rest! Good base to build on for the attestation reason explanation as well.
Co-authored-by: haworku <haworku@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MCR-3600
statutoryRegulatoryAttestation
toContractRevisionTable
statutoryRegulatoryAttestation
toContractFormDataType
Domain typesstatutoryRegulatoryAttestation
toContractInfo
Protobuf schemastatutoryRegulatoryAttestation
toUnlockedHealthPlanFormDataType
andLockedHealthPlanFormDataType
statutoryRegulatoryAttestation
toapp-web/src/common-code/proto/healthPlanFormDataProto/zodSchemas.ts
.updateDraftContractWithRates
andunlockContract
handler to updatestatutoryRegulatoryAttestation
submitHealthPlanPackage
resolver to validate onstatutoryRegulatoryAttestation
contractFormDataToDomainModel
andconvertContractWithRatesToFormData
forstatutoryRegulatoryAttestation
438-attestation
toDomain
andtoProtoBuffer
forstatutoryRegulatoryAttestation
Contract Details
pageContractDetails.test.ts
andContractDetailsSummarySection.test.ts
.useLDClient.allFlags
method for jest testsMCR-3605
Contract details
page.Related issues
Screenshots
Test cases covered
Unit Tests
submitHealthPlanPackage.test.ts
'errors when contract 4348 attestation question is undefined'
'successfully submits when contract 4348 attestation question is valid'
-
ContractDetailsSummarySection.test.ts
'displays correct contract 438 attestation yes and no text'
ContractDetails.test.ts
'renders 438 attestation question without errors'
'errors when continuing without answering 438 attestation question'
Cypress Tests:
fillOutBaseContractDetails
andfillOutAmendmentToBaseContractDetails
command. Added 438 attestation answer selection.stubFeatureFlags
command. Set438-attestation
flag to true on all tests.QA guidance