-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-3772 MCR-3771 Edit and submit standalone rate #2238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, so excited for us to move off HPP
services/app-web/src/pages/StateSubmission/RateDetails/V2/RateDetailsV2.tsx
Outdated
Show resolved
Hide resolved
Reviewed AC for tickets:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught one small bug in this PR
If you edit a standalone rate as a State user, submit the edit, then login as a CMS user and click the Rate Reviews
tab on the CMS dashboard the Rate Review
name comes back as Missing Field
:
If you click into it you are met with Unknown Rate Name
as well:
I've been able to replicate this consistently
@ruizajtruss TY - looking at the api and the error message this is an issue with how |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! good catch @ruizajtruss
@@ -975,7 +975,7 @@ type ContractFormData { | |||
} | |||
|
|||
"Either new capitation rates (NEW) or updates to previously certified capitation rates (AMENDMENT)" | |||
enum RateType { | |||
enum RateAmendmentType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the name on this because I was seeing types getting confused in my editor when RateType
was both
- the enum for a rate's type (radio button response)
- the complex data object coming back from apollo client representing the entire rate (the full data model).
@@ -0,0 +1,37 @@ | |||
/* | |||
Recursively replaces all nulls with undefineds | |||
GQL return <Maybe> types are T | null instead of T | undefined which match our zod .optional() domain types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macrael I looked into changing graphql return types to be more generous via codegen settings first in the maybeValue
but I was still seeing type issues. Feels like this could be something to look at more holistically. For now, doing this hack again (what we did in toDomain
with protos) to quickly get around it in order to move on
Summary
🔍 Most important changes here are to the new files in the
V2
folder. That is the new rate details page and standalone form.Related issues
https://jiraent.cms.gov/browse/MCR-3772
https://jiraent.cms.gov/browse/MCR-3771
Test cases covered
No tests implemented. We are not turning this on for awhile. I moved testing out this ticket and into new ticket.
QA guidance
Please run through the manual QA steps on these tickets and check the acceptance criteria. No automated tests yet.