Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCR-3886] Display the shared rate UI on historic submissions #2326

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

pearl-truss
Copy link
Contributor

Summary

This PR displays the shared rates UI on the uploads table of the ReviewSubmit page for historic submissions

  • "historic" submissions are determined if the packagesWithSharedRateCerts field is populated (going forward this field this will not be used)
  • While it was included as AC for this ticket, removing the "is this rate cert uploaded to any other submissions" field was already removed when the linked rates flag is on

Related issues

https://jiraent.cms.gov/browse/MCR-3886

Screenshots

V1 version
Screenshot 2024-03-15 at 11 52 42 AM

V2 version
Screenshot 2024-03-15 at 11 53 05 AM

Test cases covered

  • shared rate UI is present when rate is shared
  • shared rate UI is not present when the rate isn't shared

QA guidance

  • Create a submission with the linked rates flag off so that you can populate the "is this uploaded to other submissions" field on the Rate Details page
  • Once on the ReviewSubmit page turn the linked rates flag on and ensure that the UploadsTable UI under the Rate Details section displays the shared rate UI

@pearl-truss pearl-truss marked this pull request as ready for review March 15, 2024 16:14
Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I forget what the plan is with linked rates and documents

@pearl-truss pearl-truss merged commit d04b07a into main Mar 18, 2024
28 checks passed
@pearl-truss pearl-truss deleted the mcr-3886-remove-cert-field branch March 18, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants