-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix another problem with Tealium load #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for initial page load and immediately for subsequent page loads
haworku
changed the title
Fix another problemTealium load
Fix another problem with Tealium load
Mar 22, 2024
|
…, that seems alright
pearl-truss
approved these changes
Apr 2, 2024
mojotalantikite
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My last fixed addressed what it should have (initial page loads work). However, it caused regression with subsequent page load functionality. Did more messing with the function calls to get both working again.
The burden of making changes and waiting to production to verify is obnoxious. I couldn't think of a good enough reason why review apps can't also send analytics (sure it pollutes the dev analytics data... but we aren't checking that). By allowing review apps to send analytics it makes it easier for someone in code review to actually check it works and speed feedback loop.
Related issues
This is based on further follow up from the BlastAnalytics team in the CMS slack
Test cases covered
QA guidance
utag.view(tagData)
function call inside useTealium in dev tools on the review app