Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another problem with Tealium load #2337

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Fix another problem with Tealium load #2337

merged 12 commits into from
Apr 2, 2024

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Mar 22, 2024

Summary

My last fixed addressed what it should have (initial page loads work). However, it caused regression with subsequent page load functionality. Did more messing with the function calls to get both working again.

The burden of making changes and waiting to production to verify is obnoxious. I couldn't think of a good enough reason why review apps can't also send analytics (sure it pollutes the dev analytics data... but we aren't checking that). By allowing review apps to send analytics it makes it easier for someone in code review to actually check it works and speed feedback loop.

Related issues

This is based on further follow up from the BlastAnalytics team in the CMS slack

Test cases covered

  • n/a

QA guidance

  • Add a breakpoint at the utag.view(tagData) function call inside useTealium in dev tools on the review app
  • This breakpoint should be hit every time we change pages on the application.

@haworku haworku changed the title Fix another problemTealium load Fix another problem with Tealium load Mar 22, 2024
@haworku haworku marked this pull request as ready for review March 22, 2024 20:46
@haworku haworku marked this pull request as draft March 22, 2024 21:28
@haworku
Copy link
Contributor Author

haworku commented Mar 22, 2024

Ugh I'm seeing this firing multiple times for certain page loads now. For example clicking "start new submission" makes it get evaluated three times. This is resolved.

@haworku haworku marked this pull request as ready for review March 26, 2024 13:25
@haworku haworku merged commit 605a955 into main Apr 2, 2024
28 checks passed
@haworku haworku deleted the tealium branch April 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants