Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ReviewSubmitV2: Hide shared rates across submission when linked rates flag is on #2340

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Mar 25, 2024

Summary

We want to show the legacy UI (rates across submissions) only for the submission summary experience. This is for historical data reasons.

For unlocked contracts currently being edited - e.g. Review and Submit - let's hide the old SHARED tag and related submissions field in the documents table.

Related issues

product/design review on
https://jiraent.cms.gov/browse/MCR-3886

Test cases covered

  • renders shared rate certifications when submission is locked
  • does not render shared rate cert info if submission is being unlocked and being edited

QA guidance

  • Look at legacy submission that has the old "rates across submissions" feature - such as MCR-MN-016
  • See shared tag should be visible and linked submissions column is present
  • Turn ON linked rates field
  • See shared tag should NOT be visible and linked submissions column will NOT be present on ReviewSubmitb2

@haworku haworku changed the title Hide the shared rates across submission when linked rates flag is on for ReviewSubmit fix ReviewSubmitV2: Hide shared rates across submission when linked rates flag is on Mar 25, 2024
@haworku haworku marked this pull request as ready for review March 26, 2024 13:12
Copy link
Contributor

@ruizajtruss ruizajtruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@macrael macrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. And so for future submitted rates that don't have this field, refreshPackagesWIthSharedRateCert will return undefined, right?

@haworku haworku merged commit 79a4f2b into main Mar 27, 2024
28 checks passed
@haworku haworku deleted the hide-rates-across-submissions branch March 27, 2024 14:57
@haworku
Copy link
Contributor Author

haworku commented Mar 27, 2024

@macrael yes! from reading the code that what is expected. we can easily confirm this once we have ability to submit new rates and submit unlocked rates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants