-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MCR-3988 document dates working again #2369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Your change to the mock data may conflict with stuff on Pearl's branch
@@ -309,7 +309,7 @@ export const ContractDetailsSummarySection = ({ | |||
? new Date( | |||
documentDateLookupTable.previousSubmissionDate | |||
) | |||
: undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we had to switch from undefined to nulls here. Totally fine but I'm curious. in general I only expect to see nulls when dealing directly with Apollo GQL data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this choice for React reasons, not GQL. Because this was previously an optional prop, the component is used in about 6 places, and the bug was that the date was present in some expected places and not in others it was very for me difficult to tell if data was coming back unexpected as undefined OR if it was just a case where the prop wasn't passed in at all intentionally.
I changed to a required prop. That means places using this component have to be clear when there is no previousSubmissionDate using explicit null
Summary
This PR is related to #1827. That code only partially fixed the problem.
Product review found there were still caseswhere
dateAdded
was missing in the UploadedDocumentsTable. It seemed to depend on if package was submitted once or resubmitted.I found that
packageSubmission
array was empty on an unlocked submission and only the draft revision was populated. However, after merging main today that bug seems goneRelated issues
https://jiraent.cms.gov/browse/MCR-3988
Test cases covered
I added one unit test.
I also added a check to cypress that
N/A
is not appearing on submission summary pages (that's the screen reader only experience when fields are missing).QA guidance
Steps for full regression test of date added document table
Submission summary
Rate summary
ReviewSubmit (aka state user view)
QuestionResponse