-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-4052 Re-implement unlock submission #2376
Conversation
Proposing that we merge this with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that unlock is working but visually in the UI on the submission summary page the unlock banner doesn't appear until page reload
@@ -180,23 +193,48 @@ export const UnlockSubmitModalV2 = ({ | |||
case 'SUBMIT_RATE' || 'RESUBMIT_RATE': | |||
console.info('submit/resubmit rate not implemented yet') | |||
break | |||
case 'SUBMIT_CONTRACT': | |||
case 'SUBMIT_CONTRACT' || 'RESUBMIT_CONTRACT': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes a regression with resubmitting. I don't see why ||
wouldn't work here but I found that it causes the logic of this case not to be hit with resubmit
TY! I'll check the resubmit logic. That seems like a blocker The unlock banner not showing to reload is the bug cypress caught, forgot to mention I'm looking at that but didn't think it should block turning unlock back on for other testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when will we enable the new cypress tests? Once linked rates is on?
@macrael I put this up to move it through to unblock acceptance testing. I still plan to bring in the skipped test ASAP, actively working on this today. After the flag turns on we will need a whole effort around cypress to get the rest of the tests on and cleaned up. I was going to make a Cypress ticket for this in the Contract API epic, I also added it to the frontend refactor plan |
@pearl-truss FYI I fixed resubmit. I've been resubmitting in review app with linked rates flag on and off and seeing it work, no errors. I forgot to ask how you knew resubmit wasn't working though, I'm assuming there was an obvious error meesage? Or was it something more subtle? |
There wasn't an error message and it appeared to go through (green success banner) but back on the dashboard the submission still appeared as unlocked (even on page refresh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Summary
SubmissionSummaryV2
.Related issues
https://jiraent.cms.gov/browse/MCR-3943
https://jiraent.cms.gov/browse/MCR-3943
Screenshots
Test cases covered
QA guidance