Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shared rates across submissions behavior for unlocked packages with linked rates flag on #2394

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Apr 30, 2024

Summary

Got further clarification on expected behavior of our legacy UI once Linked Rates is turned on.

State users viewing unlocked packages that previously used the "rates across submissions" feature should NOT see in the data on ReviewSubmit. However, viewing SubmissionSummary, should see the UI. Adjusted the documents tables and tests to reflect this.

Related issues

slight tweak to work on #2387

Screenshots

Test cases covered

  • still renders SHARED tag to state user on submission summary when linked rates flag on
  • does not render SHARED tag to state user on review submit when linked rates flag on
  • hides the legacy shared rates across submissions UI for state users when unlocked

QA guidance

Copy link
Contributor

@pearl-truss pearl-truss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haworku haworku merged commit 9c1ebd3 into main Apr 30, 2024
28 checks passed
@haworku haworku deleted the adjust-state-user-unlocked-experience branch April 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants