Design review: Redundant Rates display cleanup #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 41e9bf8.
…ange to make in future PR
JasonLin0991
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Styling tweaks and getting "Unknown Program" to display for missing programs. This is responding to two issues raised in design review 1. container elements and layouts looking more similar to figma 2. blank spaces next to programs list in the link your rates dropdown.
I also moved
FormContainerto the components folder since its reuseable even outside the submission formRelated issues
https://jiraent.cms.gov/browse/MCR-4152
Screenshots
Before:
After:
