Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review: Redundant Rates display cleanup #2670

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Aug 16, 2024

Summary

Styling tweaks and getting "Unknown Program" to display for missing programs. This is responding to two issues raised in design review 1. container elements and layouts looking more similar to figma 2. blank spaces next to programs list in the link your rates dropdown.

I also moved FormContainer to the components folder since its reuseable even outside the submission form

Related issues

https://jiraent.cms.gov/browse/MCR-4152

Screenshots

Before:
Screenshot 2024-08-16 at 4 07 26 PM

After:
Screenshot 2024-08-16 at 3 31 19 PM

Copy link
Contributor

@JasonLin0991 JasonLin0991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link rates looks great.

Replace rates got shrunk

@haworku haworku merged commit c829909 into main Aug 27, 2024
28 checks passed
@haworku haworku deleted the redundant-rates-cleanup branch August 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants