Extended analysis to ignore fputc (#2031)

* extended analysis to ignore fputc * fixed format --------- Co-authored-by: Rasmit Devkota <rdatch101@gmail.com>
EnzymeAD · Aug 7, 2024 · e5888a4 · e5888a4
1 parent 87eed6b
commit e5888a4
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/enzyme/Enzyme/ActivityAnalysis.cpp b/enzyme/Enzyme/ActivityAnalysis.cpp
@@ -222,6 +222,7 @@ const StringSet<> KnownInactiveFunctions = {
     "vprintf",
     "vsnprintf",
     "puts",
+    "fputc",
     "fflush",
     "__kmpc_for_static_init_4",
     "__kmpc_for_static_init_4u",

diff --git a/enzyme/Enzyme/Enzyme.cpp b/enzyme/Enzyme/Enzyme.cpp
@@ -348,6 +348,7 @@ bool attributeKnownFunctions(llvm::Function &F) {
       "_ZNKSt8__detail20_Prime_rehash_policy14_M_need_rehashEmmm",
       "fprintf",
       "fwrite",
+      "fputc",
       "strtol",
       "getenv",
       "memchr",

diff --git a/enzyme/Enzyme/EnzymeLogic.cpp b/enzyme/Enzyme/EnzymeLogic.cpp
@@ -6343,6 +6343,7 @@ llvm::Function *EnzymeLogic::CreateNoFree(RequestContext context, Function *F) {
 
   StringSet<> NoFrees = {"mpfr_greater_p",
                         "fprintf",
+                        "fputc",
                          "memchr",
                          "time",
                          "strlen",

diff --git a/enzyme/Enzyme/MLIR/Analysis/ActivityAnalysis.cpp b/enzyme/Enzyme/MLIR/Analysis/ActivityAnalysis.cpp
@@ -106,6 +106,7 @@ static const std::set<std::string> KnownInactiveFunctions = {
     "vprintf",
     "vsnprintf",
     "puts",
+    "fputc",
     "fflush",
     "__kmpc_for_static_init_4",
     "__kmpc_for_static_init_4u",

diff --git a/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp b/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp
@@ -5549,7 +5549,8 @@ void TypeAnalyzer::visitCallBase(CallBase &call) {
     }
 
     if (funcName == "__cxa_guard_acquire" || funcName == "printf" ||
-        funcName == "vprintf" || funcName == "puts" || funcName == "fprintf") {
+        funcName == "vprintf" || funcName == "puts" || funcName == "fputc" ||
+        funcName == "fprintf") {
       updateAnalysis(&call, TypeTree(BaseType::Integer).Only(-1, &call), &call);
     }
 

diff --git a/enzyme/Enzyme/Utils.h b/enzyme/Enzyme/Utils.h
@@ -655,7 +655,7 @@ static inline bool endsWith(llvm::StringRef string, llvm::StringRef suffix) {
 
 static inline bool isCertainPrint(const llvm::StringRef name) {
   if (name == "printf" || name == "puts" || name == "fprintf" ||
-      name == "putchar" ||
+      name == "putchar" || name == "fputc" ||
       startsWith(name,
                  "_ZStlsISt11char_traitsIcEERSt13basic_ostreamIcT_ES5_") ||
       startsWith(name, "_ZNSolsE") || startsWith(name, "_ZNSo9_M_insert") ||