[mlir] move alias lattice update to relevant transfer function (#1573)

enzyme/Enzyme/MLIR/Analysis/AliasAnalysis.cpp

@@ -366,6 +366,19 @@ void enzyme::PointsToPointerAnalysis::visitOperation(Operation *op,
 
  SmallVector<MemoryEffects::EffectInstance> effects;
  memory.getEffects(effects);
+
+ // If the operation allocates fresh memory and doesn't write into it, that
+ // memory is known not to point to any known alias class.
+ if (effects.size() == 1 &&
+ isa<MemoryEffects::Allocate>(effects.front().getEffect()) &&
+ effects.front().getValue()) {
+ const auto *destClasses =
+ getOrCreateFor<AliasClassLattice>(op, effects.front().getValue());
+ propagateIfChanged(
+ after, after->setPointingToEmpty(destClasses->getAliasClassesObject()));
+ return;
+ }
+
  for (const auto &effect : effects) {
  if (!isa<MemoryEffects::Write>(effect.getEffect()))
  continue;
@@ -860,14 +873,6 @@ void enzyme::AliasAnalysis::transfer(
  result->getPoint(),
  originalClasses.getOriginalClass(result->getPoint(), debugLabel));
  propagateIfChanged(result, result->join(fresh));
-
- // The pointer to freshly allocated memory is known not to point to
- // anything.
- // TODO(zinenko): this is a bit strange to update _another_ lattice
- // here.
- auto *pointsTo = getOrCreate<PointsToSets>(op);
- propagateIfChanged(pointsTo, pointsTo->setPointingToEmpty(
- fresh.getAliasClassesObject()));
  }
  }
  } else if (isa<MemoryEffects::Read>(effect.getEffect())) {

enzyme/test/MLIR/AliasAnalysis/func_attributes.mlir

@@ -115,7 +115,7 @@ func.func private @callee(%ptr : !llvm.ptr {llvm.readonly}) attributes {
 }
 
 // CHECK: points-to-pointer sets
-// CHECK-NEXT: <empty>
+// CHECK: <empty>
 // CHECK-LABEL @call_other_none_arg_rw_readonly
 func.func @call_other_none_arg_rw_readonly(%input: !llvm.ptr {enzyme.tag = "input"}) {
  call @callee(%input) : (!llvm.ptr) -> ()