Debug Info Improvements #1294
Closed
Debug Info Improvements #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgymnich
commented
Jun 21, 2023
•
tgymnich
commented
- would have loved to move shadow allocations from entry to inventry. But thats going to break all tests.
tgymnich
force-pushed
the
debug-info
branch
3 times, most recently
from
5d6721a
to
e684c08
Compare
wsmoses
reviewed
Jun 27, 2023
| DIBuilder DebugBuilder(*I.getModule()); | ||
| auto var = newI->getVariable(); | ||
| auto nv = DebugBuilder.createAutoVariable( | ||
| var->getScope(), ("d_" + var->getName()).str(), var->getFile(), |
There was a problem hiding this comment.
I'd rather have something short
tgymnich
force-pushed
the
debug-info
branch
4 times, most recently
from
18a0a5a
to
81bb856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.