cublas support #1453
Merged
cublas support #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Sep 23, 2023
ZuseZ4
commented
Oct 9, 2023
tgymnich
reviewed
Oct 16, 2023
enzyme/Enzyme/Utils.cpp
Outdated
| @@ -655,8 +655,7 @@ void callMemcpyStridedBlas(llvm::IRBuilder<> &B, llvm::Module &M, BlasInfo blas, | |||
| void callMemcpyStridedLapack(llvm::IRBuilder<> &B, llvm::Module &M, | |||
| BlasInfo blas, llvm::ArrayRef<llvm::Value *> args, | |||
| llvm::ArrayRef<llvm::OperandBundleDef> bundles) { | |||
| std::string copy_name = | |||
| (blas.prefix + blas.floatType + "lacpy" + blas.suffix).str(); | |||
| std::string copy_name = blas.prefix + blas.floatType + "lacpy" + blas.suffix; | |||
There was a problem hiding this comment.
unnecessary heap allocations for construction temporary std::strings!
https://godbolt.org/z/Ecdcc5beK
|
Note macos Julia CI is failing which we'll need to fix. Merging now to avoid a bunch of git nonsense per @ZuseZ4 |
MilesCranmer
pushed a commit
to MilesCranmer/Enzyme
that referenced
this pull request
Jul 24, 2024
* rewrite calls * Fix * remove nulls * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.