Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transposed lda on cache #1501

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Fix transposed lda on cache #1501

merged 14 commits into from
Oct 26, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Oct 24, 2023

@gaurav-arya this was resulting in memory errors if a matrix was cached and non-square

@ZuseZ4
Copy link
Member

ZuseZ4 commented Oct 24, 2023

@wsmoses /h/344/drehwald/prog/Enzyme/enzyme/test/Enzyme/ReverseMode/blas/gemv_c_loop3_matcopy.ll
switched from select false in all cases to select true in all cases.
Looks suspicious to me.

@ZuseZ4 ZuseZ4 enabled auto-merge October 26, 2023 03:24
@ZuseZ4 ZuseZ4 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit d0c9b9b Oct 26, 2023
35 of 57 checks passed
@wsmoses wsmoses deleted the blasnonsquare branch November 8, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants