Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeAnalysis speed up Canonicalize #1747

Merged
merged 2 commits into from
Feb 21, 2024
Merged

TypeAnalysis speed up Canonicalize #1747

merged 2 commits into from
Feb 21, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Feb 21, 2024

Again doing a assert equal to old implementation first, then will remove and merge.

@ZuseZ4
Copy link
Member

ZuseZ4 commented Feb 21, 2024

improves compile time by 2x to 3.5x (impact becomes larger for bigger vectors).
Will check at some later point if it brings compile times down to something linear.
Updating a vector with 100 entries goes from 2s to 1s, for a vector with 500 entries from 10s to 4s.

Checked some slightly more realistic (larger) functions and unfortunately this mostly seems to help when adding more small functions, less when having fewer larger functions.
E.g. having 5 functions with each update a subset of 500 vec entries only improves from 180s to 120s.

For scale, real molecules have at least in the 10k entries, easily 100k or even more.

@wsmoses wsmoses added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 638ac37 Feb 21, 2024
46 of 54 checks passed
@wsmoses wsmoses deleted the canonspeed branch February 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants